Updating split range from [0, 1] to (0, 1) in keras.utils.split_dataset #18028

SuryanarayanaY · 2023-04-21T15:34:29Z

In the tf.keras.utils.split_dataset API , that can be used to split a dataset into left and right parts, the documentation states it splits dataset into left half and right half where the parts need not be equal parts.The split can be anything in range (0, 1). Hence I thought to replace the word half with part.

Also in the Args section of documentation and exception handling in source code the range for split used as [0, 1] which is not a correct notation as 0 and 1 are actually not inclusive in the range and raises exception if we use either 0 or 1 for either of left_size or right_size for splitting the dataset. Hence I have replaced [0, 1] with (0, 1) to make it more intuitive. Thanks.

…taset to make it more intuitive In the split_dataset API which is used to split a dataset into left and right parts. But documentation states it splits dataset into left half and right half where the parts need not be equal parts.The split can be anything in range(0, 1).Hence I think to replace the word half with part. Also in the argument section and exception section the range for split used as [0, 1] which is not a correct notation as 0 and 1 are actually excluded in the range and raises exception if we use either 0 or 1 for either of left_size or right_size for splitting the dataset. Hence i have replaced [0, 1] with (0,1) to make it more intuitive. Thanks.

fchollet · 2023-04-21T16:44:48Z

keras/utils/dataset_utils.py


    Args:
        dataset: A `tf.data.Dataset` object, or a list/tuple of arrays with the
          same length.
-        left_size: If float (in the range `[0, 1]`), it signifies
+        left_size: If float (in the range `(0, 1)`), it signifies


Please keep the brackets for the range -- it mimics math notation for ranges.

I am not getting your question. Actually the API raises error if split includes either 0 or 1. As per maths notation
[0, 1] means both 0 and 1 are included in the range. But here these are not valid values for argument. Hence I am proposing the range as (0, 1) . Am I understand it correctly ?

keras/utils/dataset_utils.py

gbaned · 2023-05-04T08:16:29Z

Hi @SuryanarayanaY Can you please check @fchollet's comments ? Thank you!

github-actions · 2023-05-19T01:52:42Z

This PR is stale because it has been open for 14 days with no activity. It will be closed if no further activity occurs. Thank you.

gbaned · 2023-06-01T07:22:11Z

Hi @SuryanarayanaY Any update on this PR? Please. Thank you!

gbaned · 2023-06-08T08:20:44Z

Hi @SuryanarayanaY Any update on this PR? Please. Thank you!

SuryanarayanaY · 2023-06-13T06:58:26Z

Added my comments above

gbaned · 2023-06-21T05:27:32Z

Hi @fchollet Can you please assist on above comments from @SuryanarayanaY. Thank you!

fchollet · 2023-06-22T17:18:34Z

The notation (0, 1) is ambiguous and not standard. Instead, you can just say "[0, 1] (excluding the boundary values 0 and 1)" which is clearer.

Updated the range notation as requested

fchollet · 2023-06-29T17:19:17Z

keras/utils/dataset_utils.py


    Args:
        dataset: A `tf.data.Dataset` object, or a list/tuple of arrays with the
          same length.
-        left_size: If float (in the range `[0, 1]`), it signifies
+        left_size: If float (in the range "[0, 1] (excluding the boundary values 0 and 1)"), it signifies


use backticks for the [] range

remove " quotes

make sure the lines are under 80 chars

keras/utils/dataset_utils.py

gbaned · 2023-07-17T06:06:42Z

Hi @SuryanarayanaY Can you please check @fchollet's comments and keep us posted ? Thank you!

Don e the formatting changes as requested

SuryanarayanaY · 2023-07-19T12:23:33Z

Apologies for the delay. Done the changes as requested. Thanks

keras/utils/dataset_utils.py

grasskin · 2023-08-14T08:46:54Z

keras/utils/dataset_utils.py

+        left_size: If float (in the range `[0, 1]` (excluding the
+          boundary values 0 and 1)), it signifies the fraction of the data to
+          pack in the left dataset.If integer, it signifies the number of
+          samples to pack in the left dataset.If `None`, it uses the complement


Same as above

keras/utils/dataset_utils.py

gbaned · 2023-08-22T07:15:28Z

Hi @SuryanarayanaY Can you please check @grasskin's comments and keep us posted ? Thank you!

Done the formatting as suggested. Thanks

SuryanarayanaY · 2023-08-24T04:40:46Z

Apologies for the delay.Done the suggested changes.

Removed trailing whitespaces as suggested by lint.

grasskin

LGTM

sachinprasadhs · 2023-09-19T16:26:54Z

Hello, Thank you for submitting a pull request.

We're currently in the process of migrating the new Keras 3 code base from keras-team/keras-core to keras-team/keras.
Consequently, merging this PR is not possible at the moment. After the migration is successfully completed, feel free to reopen this PR at keras-team/keras if you believe it remains relevant to the Keras 3 code base. If instead this PR fixes a bug or security issue in legacy tf.keras, you can instead reopen the PR at keras-team/tf-keras, which hosts the TensorFlow-only, legacy version of Keras.

google-ml-butler bot added the size:S label Apr 21, 2023

google-ml-butler bot assigned gbaned Apr 21, 2023

gbaned requested a review from fchollet April 21, 2023 16:17

google-ml-butler bot added the keras-team-review-pending Pending review by a Keras team member. label Apr 21, 2023

fchollet reviewed Apr 21, 2023

View reviewed changes

fchollet removed the keras-team-review-pending Pending review by a Keras team member. label Apr 21, 2023

gbaned added the stat:awaiting response from contributor label May 4, 2023

github-actions bot added the stale label May 19, 2023

github-actions bot removed the stale label Jun 2, 2023

google-ml-butler bot removed the stat:awaiting response from contributor label Jun 13, 2023

gbaned added the keras-team-review-pending Pending review by a Keras team member. label Jun 21, 2023

Update dataset_utils.py

9bc86d6

Updated the range notation as requested

gbaned added the kokoro:force-run label Jun 28, 2023

kokoro-team removed the kokoro:force-run label Jun 28, 2023

sachinprasadhs removed the keras-team-review-pending Pending review by a Keras team member. label Jun 29, 2023

fchollet reviewed Jun 29, 2023

View reviewed changes

keras/utils/dataset_utils.py Outdated Show resolved Hide resolved

gbaned added the stat:awaiting response from contributor label Jul 17, 2023

Update dataset_utils.py

0a51eeb

Don e the formatting changes as requested

sampathweb requested a review from grasskin August 10, 2023 17:10

sampathweb added stat:awaiting keras-eng Awaiting response from Keras engineer and removed keras-team-review-pending Pending review by a Keras team member. labels Aug 10, 2023

google-ml-butler bot added the awaiting review label Aug 10, 2023

grasskin suggested changes Aug 14, 2023

View reviewed changes

grasskin added stat:awaiting response from contributor and removed stat:awaiting keras-eng Awaiting response from Keras engineer awaiting review labels Aug 14, 2023

Update dataset_utils.py

a0b1378

Done the formatting as suggested. Thanks

google-ml-butler bot removed the stat:awaiting response from contributor label Aug 24, 2023

gbaned requested a review from grasskin August 24, 2023 05:05

google-ml-butler bot added the awaiting review label Aug 24, 2023

Update dataset_utils.py

9c5d415

Removed trailing whitespaces as suggested by lint.

grasskin approved these changes Aug 25, 2023

View reviewed changes

google-ml-butler bot added kokoro:force-run ready to pull Ready to be merged into the codebase labels Aug 25, 2023

kokoro-team removed the kokoro:force-run label Aug 25, 2023

gbaned added ready to pull Ready to be merged into the codebase and removed ready to pull Ready to be merged into the codebase awaiting review labels Sep 1, 2023

gbaned added ready to pull Ready to be merged into the codebase and removed ready to pull Ready to be merged into the codebase labels Sep 12, 2023

sachinprasadhs closed this Sep 19, 2023

google-ml-butler bot removed the ready to pull Ready to be merged into the codebase label Sep 19, 2023

SuryanarayanaY deleted the patch-1 branch October 23, 2023 14:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Updating split range from [0, 1] to (0, 1) in keras.utils.split_dataset #18028

Updating split range from [0, 1] to (0, 1) in keras.utils.split_dataset #18028

SuryanarayanaY commented Apr 21, 2023

fchollet Apr 21, 2023

SuryanarayanaY Jun 13, 2023

gbaned commented May 4, 2023

github-actions bot commented May 19, 2023

gbaned commented Jun 1, 2023

gbaned commented Jun 8, 2023

SuryanarayanaY commented Jun 13, 2023

gbaned commented Jun 21, 2023

fchollet commented Jun 22, 2023

fchollet Jun 29, 2023

gbaned commented Jul 17, 2023

SuryanarayanaY commented Jul 19, 2023

grasskin Aug 14, 2023

gbaned commented Aug 22, 2023

SuryanarayanaY commented Aug 24, 2023

grasskin left a comment

sachinprasadhs commented Sep 19, 2023

Updating split range from [0, 1] to (0, 1) in keras.utils.split_dataset #18028

Updating split range from [0, 1] to (0, 1) in keras.utils.split_dataset #18028

Conversation

SuryanarayanaY commented Apr 21, 2023

fchollet Apr 21, 2023

Choose a reason for hiding this comment

SuryanarayanaY Jun 13, 2023

Choose a reason for hiding this comment

gbaned commented May 4, 2023

github-actions bot commented May 19, 2023

gbaned commented Jun 1, 2023

gbaned commented Jun 8, 2023

SuryanarayanaY commented Jun 13, 2023

gbaned commented Jun 21, 2023

fchollet commented Jun 22, 2023

fchollet Jun 29, 2023

Choose a reason for hiding this comment

gbaned commented Jul 17, 2023

SuryanarayanaY commented Jul 19, 2023

grasskin Aug 14, 2023

Choose a reason for hiding this comment

gbaned commented Aug 22, 2023

SuryanarayanaY commented Aug 24, 2023

grasskin left a comment

Choose a reason for hiding this comment

sachinprasadhs commented Sep 19, 2023