-
Notifications
You must be signed in to change notification settings - Fork 19.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add scan
op
#19681
Add scan
op
#19681
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #19681 +/- ##
==========================================
+ Coverage 78.42% 78.49% +0.07%
==========================================
Files 498 498
Lines 45551 45699 +148
Branches 8394 8448 +54
==========================================
+ Hits 35723 35872 +149
+ Misses 8094 8093 -1
Partials 1734 1734
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM -- great job!
Related to #19519
Originally,
tf.scan
stacks the output of thef
as the final output and doesn't support the separatedcarry
throughout the loop iterations.I've reimplemented
scan
for tensorflow backend to align with the behavior ofjax.lax.scan
.However, the current implementation requires that the output (
y
) off
must have the same shape/dtype ascarry
. This is not required in other backends.