Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Async logs - evaluate future inside the executor context #20266

Closed
wants to merge 1 commit into from

Conversation

sampathweb
Copy link
Collaborator

Move the future evaluation to inside the with Executor context in which its created.

@codecov-commenter
Copy link

codecov-commenter commented Sep 17, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 78.96%. Comparing base (6d569e4) to head (e79c3ee).

Files with missing lines Patch % Lines
keras/src/trainers/trainer.py 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #20266      +/-   ##
==========================================
- Coverage   78.96%   78.96%   -0.01%     
==========================================
  Files         505      505              
  Lines       48005    48006       +1     
  Branches     8839     8840       +1     
==========================================
  Hits        37906    37906              
  Misses       8294     8294              
- Partials     1805     1806       +1     
Flag Coverage Δ
keras 78.81% <75.00%> (-0.01%) ⬇️
keras-jax 62.22% <75.00%> (-0.01%) ⬇️
keras-numpy 57.37% <75.00%> (-0.01%) ⬇️
keras-tensorflow 63.61% <75.00%> (-0.01%) ⬇️
keras-torch 62.27% <75.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sampathweb
Copy link
Collaborator Author

Deleting this PR since its addressed offline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants