Fix CompileLoss with undefined loss argument
#20296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #20296 +/- ##
==========================================
+ Coverage 78.82% 78.84% +0.01%
==========================================
Files 511 511
Lines 48974 48979 +5
Branches 9018 9019 +1
==========================================
+ Hits 38605 38617 +12
+ Misses 8505 8499 -6
+ Partials 1864 1863 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
google-ml-butler
bot
added
kokoro:force-run
ready to pull
google-ml-butler
bot
removed
ready to pull
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #20243
Actually, #20243 works as expected in torch and jax backends without this PR. The underlying issue in TF backend has been resolved.
The root cause was that we used
popin_filter_unused_inputswithinCompileLoss, which is not allowed in a jitted tf graph. The solution is to avoid modifying the incoming data.A test has been added to verify the implementation.