Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding ifft2 method to ops #20447

Merged
merged 3 commits into from
Nov 5, 2024
Merged

adding ifft2 method to ops #20447

merged 3 commits into from
Nov 5, 2024

Conversation

rohithpudari
Copy link
Contributor

Added implementation of ifft2 to ops.

fixes #20437

Copy link

google-cla bot commented Nov 4, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@codecov-commenter
Copy link

codecov-commenter commented Nov 4, 2024

Codecov Report

Attention: Patch coverage is 77.77778% with 10 lines in your changes missing coverage. Please review.

Project coverage is 82.01%. Comparing base (c052cea) to head (98b704c).
Report is 24 commits behind head on master.

Files with missing lines Patch % Lines
keras/src/ops/math.py 62.50% 5 Missing and 4 partials ⚠️
keras/api/_tf_keras/keras/ops/__init__.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #20447      +/-   ##
==========================================
- Coverage   82.01%   82.01%   -0.01%     
==========================================
  Files         514      514              
  Lines       47194    47239      +45     
  Branches     7408     7413       +5     
==========================================
+ Hits        38706    38741      +35     
- Misses       6698     6704       +6     
- Partials     1790     1794       +4     
Flag Coverage Δ
keras 81.86% <77.77%> (-0.01%) ⬇️
keras-jax 64.91% <48.88%> (-0.02%) ⬇️
keras-numpy 59.86% <51.11%> (-0.01%) ⬇️
keras-tensorflow 65.90% <55.55%> (-0.01%) ⬇️
keras-torch 64.85% <48.88%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

keras/src/backend/jax/math.py Show resolved Hide resolved
keras/src/backend/tensorflow/math.py Outdated Show resolved Hide resolved
keras/src/backend/numpy/math.py Show resolved Hide resolved
keras/src/backend/torch/math.py Show resolved Hide resolved
Copy link
Member

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- thank you for the contribution!

@google-ml-butler google-ml-butler bot added kokoro:force-run ready to pull Ready to be merged into the codebase labels Nov 4, 2024
@fchollet fchollet merged commit 272bb90 into keras-team:master Nov 5, 2024
9 checks passed
@google-ml-butler google-ml-butler bot removed awaiting review ready to pull Ready to be merged into the codebase labels Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ifft2 method to ops
5 participants