Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress warnings for mismatched tuples and lists in functional models #20456

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

james77777778
Copy link
Contributor

Fix #20170

It should be acceptable to suppress warnings for mismatched tuples and lists in functional models, as the TF backend will automatically convert lists to tuples for input data.

@codecov-commenter
Copy link

codecov-commenter commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.01%. Comparing base (fe84076) to head (936e671).

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #20456   +/-   ##
=======================================
  Coverage   82.01%   82.01%           
=======================================
  Files         515      515           
  Lines       47275    47275           
  Branches     7422     7422           
=======================================
  Hits        38772    38772           
  Misses       6706     6706           
  Partials     1797     1797           
Flag Coverage Δ
keras 81.86% <ø> (ø)
keras-jax 64.91% <ø> (ø)
keras-numpy 59.84% <ø> (ø)
keras-tensorflow 65.91% <ø> (ø)
keras-torch 64.83% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks!

@google-ml-butler google-ml-butler bot added kokoro:force-run ready to pull Ready to be merged into the codebase labels Nov 6, 2024
@fchollet fchollet merged commit 4e71b2e into keras-team:master Nov 6, 2024
7 checks passed
@google-ml-butler google-ml-butler bot removed ready to pull Ready to be merged into the codebase kokoro:force-run labels Nov 6, 2024
@james77777778 james77777778 deleted the suppress-warnings branch November 7, 2024 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants