Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Enable CI on aarch64 #167

Merged
merged 4 commits into from
Nov 9, 2022
Merged

ci: Enable CI on aarch64 #167

merged 4 commits into from
Nov 9, 2022

Conversation

chantra
Copy link
Contributor

@chantra chantra commented Nov 8, 2022

Signed-off-by: Manu Bretelle [email protected]

@chantra chantra force-pushed the arm64 branch 4 times, most recently from 221a4c5 to ef24635 Compare November 8, 2022 23:32
@chantra
Copy link
Contributor Author

chantra commented Nov 8, 2022

At the time of testing x86_64 with llvm was failing. https://github.com/kernel-patches/vmtest/actions/runs/3423770717 is a run on arm64 only.

Signed-off-by: Manu Bretelle <[email protected]>
Depending on the architecture, the kernel has different names (bzImage,
Image.gz...). Using `make -s image_name`, the name is automatically
discovered.

Signed-off-by: Manu Bretelle <[email protected]>
Copy link
Contributor

@danielocfb danielocfb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me! Big milestone.

Are these additional test failures (new entries in DENYLIST) understood fully? Should we keep the three column format trying to capture the essence of the problem?

@chantra
Copy link
Contributor Author

chantra commented Nov 9, 2022

Are these additional test failures (new entries in DENYLIST) understood fully?

No, and they should probably be addressed separately.

Should we keep the three column format trying to capture the essence of the problem?

The 3 column format is not obvious from the file in this repo. Probably the only place where this is made more obvious is https://github.com/kernel-patches/bpf/blob/bpf-next/tools/testing/selftests/bpf/DENYLIST.s390x . Files should probably have a header explaining the format. This can go in a separate diff.

@chantra chantra merged commit 64dce15 into kernel-patches:master Nov 9, 2022
@chantra
Copy link
Contributor Author

chantra commented Nov 9, 2022

I will land this for now. #169 for file format.

@chantra chantra deleted the arm64 branch November 9, 2022 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants