-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Enable CI on aarch64 #167
Conversation
221a4c5
to
ef24635
Compare
At the time of testing x86_64 with llvm was failing. https://github.com/kernel-patches/vmtest/actions/runs/3423770717 is a run on arm64 only. |
https://lore.kernel.org/llvm/[email protected]/ Signed-off-by: Manu Bretelle <[email protected]>
Signed-off-by: Manu Bretelle <[email protected]>
Depending on the architecture, the kernel has different names (bzImage, Image.gz...). Using `make -s image_name`, the name is automatically discovered. Signed-off-by: Manu Bretelle <[email protected]>
Signed-off-by: Manu Bretelle <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me! Big milestone.
Are these additional test failures (new entries in DENYLIST) understood fully? Should we keep the three column format trying to capture the essence of the problem?
No, and they should probably be addressed separately.
The 3 column format is not obvious from the file in this repo. Probably the only place where this is made more obvious is https://github.com/kernel-patches/bpf/blob/bpf-next/tools/testing/selftests/bpf/DENYLIST.s390x . Files should probably have a header explaining the format. This can go in a separate diff. |
I will land this for now. #169 for file format. |
Signed-off-by: Manu Bretelle [email protected]