Add veristat.cfg for meta BPF objs #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The config in this patch denylists three BPF objects which we know won't work with veristat for various reasons. Nothing uses the config as of this patch - further patches will use it. Signed-off-by: Dave Marchevsky <[email protected]>
This patch adds a VERISTAT_CFG_FILE var to
run_veristat.{meta,kernel}.cfg which points to appropariate config file.
run_selftests.sh uses this with veristat's -f flag to read the config.
For meta bpf objs, this change results in the three bpf objects added in
the previous patch being ignored.
For kernel bpf objs, this patch should not have a functional effect.
Previously, VERISTAT_OBJECTS_GLOB for kernel bpf objs was using awk to
essentially do "look at allowlisted BPF objs in this veristat.cfg,
ignore comments". Using a broad glob and feeding the veristat.cfg
to veristat itself has the same effect.
Signed-off-by: Dave Marchevsky <[email protected]>
|
Great, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
veristat_meta.cfgto this repository, meant to be used with the tarball of meta bpf objs.run_selftests.shis modified to use veristat.cfg files via veristat's-fflag. See individual commit summaries for more detail.