Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for loongarch #46

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add support for loongarch #46

wants to merge 1 commit into from

Conversation

wuruilong01
Copy link

No description provided.

kernelslacker
kernelslacker requested changes Sep 24, 2023
View reviewed changes
Copy link
Owner

@kernelslacker kernelslacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

loongarch bits look ok, the other bits should be broken out, with separate explanations/commits.

ioctls/autofs.c
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this part should be a separate diff.

ioctls/scsi.c
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

separate diff.

syscalls/vmsplice.c
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

separate diff, and some explanation why ?

sysv-shm.c
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

separate diff too.

@wuruilong01
Copy link
Author

Other files have been fixed for bugs caused by SEGV and tested on LoongArch.

  • the used address to fill data should exist,otherwise trinity may get SEGV signal.
  • arg3type of vmsplice is ARG_IOVECLEN,if you modify it,you should also modify arg2 accordingly.

Sorry, I'm a beginner; perhaps fixing the errors should be done in the next submission.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kernelslacker kernelslacker kernelslacker requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wuruilong01 @kernelslacker