feat: support additional libs to kestra classpath #3604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
tchiotludo
force-pushed
the
develop
branch
2 times, most recently
from
04a5e48
to
27a81a3
Compare
|
I am concerned about the security implication of this, if this is not mandatory, I'll prefer to avoid it, if this is mandatory, we need to have a switch to be able to disable it for hardened deployment. |
|
@loicmathieu This change was initially made to allow users to have a propery way to provide custom Micronaut beans without going through Kestra's plugin mechanism (e.g., custom mn controllers ) - i.e., when we moved to the ServiceLoader for plugins. |
|
If it's really needed, we should implement it disabled by default. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.