Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): ensure child-first strategy for plugin class loading (#4621) #4622

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix(core): ensure child-first strategy for plugin class loading (#4621) #4622

wants to merge 1 commit into from

Conversation

fhussonnois
Copy link
Member

@fhussonnois fhussonnois commented Aug 9, 2024 •
edited
Loading

Changes:

  • fix child-first strategy
  • cleanup the PluginClassLoader class

Fix: #4621

With this classloader:

new-classloader

@fhussonnois fhussonnois force-pushed the fix/classloader branch 4 times, most recently from cdeee47 to f4d758c Compare August 13, 2024 09:00
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 13, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@fhussonnois
fix(core): ensure child-first strategy for plugin class loading (#4621)
2849e7c 
Changes:
- fix child-first strategy
- cleanup the PluginClassLoader class

Fix: #4621
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tchiotludo tchiotludo Awaiting requested review from tchiotludo

Assignees
No one assigned
Labels
None yet
Projects
Pull Requests
Status: To review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PluginClassLoader does't provide 'true' ClassLoadingIsolation (child-first strategy is not respected)
1 participant
@fhussonnois