Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core, jdbc): introduce a JDBC indexer #4974

Merged
merged 1 commit into from
Oct 14, 2024
Merged

Conversation

loicmathieu
Copy link
Member

Fixes #988
This is a WIP PR to introduce an indexer in JDBC.

This indexes logs, metric and executions in realtime.

A simple flow shows more than 20% perf improvement, more is expected in production as locally logs are in send to the console which is known to be not good in term of performance.

Moreover, indexing move from the queue emission to queue reception so from the executor to the indexer (TBD where it will be).

id: generate-plenty-logs
namespace: company.team

tasks:
  - id: python
    type: io.kestra.plugin.scripts.python.Script
    script: |
      for i  in range(10000):
        print("Iteration {}".format(i))

@loicmathieu loicmathieu force-pushed the feat/jdbc-indexer branch 2 times, most recently from a822926 to 0704e80 Compare September 20, 2024 14:56
@loicmathieu loicmathieu force-pushed the feat/jdbc-indexer branch 2 times, most recently from 34c8104 to 090a78f Compare October 3, 2024 15:23
@loicmathieu
Copy link
Member Author

A decision has been taken to make the standalone/webserver start an indexer automatically and to allow disabling the embedding one and starting one externally if needed.

Copy link

sonarcloud bot commented Oct 11, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
75.4% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@loicmathieu loicmathieu merged commit 5228ccf into develop Oct 14, 2024
8 of 9 checks passed
@loicmathieu loicmathieu deleted the feat/jdbc-indexer branch October 14, 2024 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Adjust log handling in JDBC backend to be written in bulk/async rather than in real-time
1 participant