Enable brotli decompression if it is available #620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
immerrr
force-pushed
the
enable-decompressing-brotli-encoded-responses
branch
from
9d94e14
to
c7b3b93
Compare
immerrr
force-pushed
the
enable-decompressing-brotli-encoded-responses
branch
2 times, most recently
from
7fbcf70
to
3e31acf
Compare
immerrr
force-pushed
the
enable-decompressing-brotli-encoded-responses
branch
from
3e31acf
to
36d72ea
Compare
|
@jairhenrique would you be able to look at this at your convenience? |
jairhenrique
approved these changes
Aug 10, 2022
CharString
suggested changes
Oct 4, 2022
| AVAILABLE_DECOMPRESSORS = {"gzip", "deflate"} | ||
| if brotli is not None: | ||
| AVAILABLE_DECOMPRESSORS.add("br") | ||
|
|
There was a problem hiding this comment.
It is easier to expand with future or custom decompressors if AVAILABLE_DECOMPRESSORS is a Dict[[str], Callable[[bytes], str]]
AVAILABLE_DECOMPRESSORS = {
"brotli": brotli.decompress,
"deflate": zlib.decompress,
"gzip": lambda body: zlib.decompress(body, zlib.MAX_WBITS | 16),
}Then decompress_body can just be
def decompress_body(body, encoding):
return AVAILABLE_DECOMPRESSORS[encoding](body)Adding a new scheme will be as easy as adding a function to the dict.
kevin1024
force-pushed
the
master
branch
3 times, most recently
from
df3997c
to
34d5384
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables brotli decompression of responses if it is available (via
brotli,brotlipyorbrotlicffi)I have added all three brotli variations to the test suite, but I'm at a bit of a loss, because
httpbinbrings inbrotlipyunconditionally, so there is no real way to test:brotli.decompress(data)API)Happy to hear any feedback, but also feel free to make any adjustments that feel right (I have enabled edits from maintainers).
Fixes #599