Refactoring 09122023 #166
Merged
Refactoring 09122023 #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
juev
commented
Dec 9, 2023
juev
commented
- private functions to helpers
- public functions to gobrew
- use os variables only on main function
- setup gobrew with one function
- setup http client with timeouts
- private functions to helpers - public functions to gobrew - use os variables only on main function - setup gobrew with one function
Summary CoverItUp: kevincobain2000/gobrew
Generated by Cover It Up. |
| @@ -73,7 +74,14 @@ func init() { | |||
| } | |||
|
|
|||
| func main() { | |||
| gb := gobrew.NewGoBrew() | |||
| homeDir, ok := os.LookupEnv("GOBREW_ROOT") | |||
There was a problem hiding this comment.
at some point, it'd be better use a struct for all those config that use env into its own struct and use tags
kevincobain2000
approved these changes
Dec 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.