Tests 10122023 #167

juev · 2023-12-11T09:31:50Z

add config for GoBrew
rewrite tests to use httptest

Resolve #127

github-actions · 2023-12-11T09:33:03Z

Summary CoverItUp: kevincobain2000/gobrew

Type	master	tests-10122023
coverage	68.8 %	69.1 % +
go-binary-size	5.8k KB	5.9k KB +
go-mod-dependencies	28	29 +
go-sec-issues	6	6
build-time	3 sec	4 sec +
unit-test-run-time	103 sec	19 sec -

Generated by Cover It Up.
View full report https://coveritup.app/kevincobain2000/gobrew

github-actions · 2023-12-11T09:38:03Z

Summary CoverItUp: kevincobain2000/gobrew

Type	master	tests-10122023
coverage	68.8 %	69.1 % +
go-binary-size	5.8k KB	5.9k KB +
go-mod-dependencies	28	29 +
go-sec-issues	6	6
build-time	3 sec	3 sec
unit-test-run-time	103 sec	18 sec -

Generated by Cover It Up.
View full report https://coveritup.app/kevincobain2000/gobrew

github-actions · 2023-12-11T09:43:37Z

Summary CoverItUp: kevincobain2000/gobrew

Type	master	tests-10122023
coverage	68.8 %	69.1 % +
go-binary-size	5.8k KB	5.9k KB +
go-mod-dependencies	28	29 +
go-sec-issues	6	6
build-time	3 sec	4 sec +
unit-test-run-time	103 sec	19 sec -

Generated by Cover It Up.
View full report https://coveritup.app/kevincobain2000/gobrew

juev · 2023-12-11T09:46:49Z

test time was improved :)

juev · 2023-12-11T10:01:06Z

I will check tests with windows

github-actions · 2023-12-11T11:15:33Z

Summary CoverItUp: kevincobain2000/gobrew

Type	master	tests-10122023
coverage	68.8 %	69.1 % +
go-binary-size	5.8k KB	5.9k KB +
go-mod-dependencies	28	29 +
go-sec-issues	6	6
build-time	3 sec	3 sec
unit-test-run-time	103 sec	19 sec -

Generated by Cover It Up.
View full report https://coveritup.app/kevincobain2000/gobrew

github-actions · 2023-12-11T11:21:57Z

Summary CoverItUp: kevincobain2000/gobrew

Type	master	tests-10122023
coverage	68.8 %	69.1 % +
go-binary-size	5.8k KB	5.9k KB +
go-mod-dependencies	28	29 +
go-sec-issues	6	6
build-time	3 sec	4 sec +
unit-test-run-time	103 sec	19 sec -

Generated by Cover It Up.
View full report https://coveritup.app/kevincobain2000/gobrew

github-actions · 2023-12-11T11:56:06Z

Summary CoverItUp: kevincobain2000/gobrew

Type	master	tests-10122023
coverage	68.8 %	68.8 %
go-binary-size	5.8k KB	5.9k KB +
go-mod-dependencies	28	29 +
go-sec-issues	6	6
build-time	3 sec	4 sec +
unit-test-run-time	103 sec	19 sec -

Generated by Cover It Up.
View full report https://coveritup.app/kevincobain2000/gobrew

github-actions · 2023-12-11T12:04:00Z

Summary CoverItUp: kevincobain2000/gobrew

Type	master	tests-10122023
coverage	68.8 %	68.4 % -
go-binary-size	5.8k KB	5.9k KB +
go-mod-dependencies	28	29 +
go-sec-issues	6	6
build-time	3 sec	4 sec +
unit-test-run-time	103 sec	19 sec -

Generated by Cover It Up.
View full report https://coveritup.app/kevincobain2000/gobrew

github-actions · 2023-12-11T12:18:07Z

Summary CoverItUp: kevincobain2000/gobrew

Type	master	tests-10122023
coverage	68.8 %	68 % -
go-binary-size	5.8k KB	5.9k KB +
go-mod-dependencies	28	29 +
go-sec-issues	6	6
build-time	3 sec	3 sec
unit-test-run-time	103 sec	19 sec -

Generated by Cover It Up.
View full report https://coveritup.app/kevincobain2000/gobrew

This reverts commit 8d1c45f.

github-actions · 2023-12-11T12:26:19Z

Summary CoverItUp: kevincobain2000/gobrew

Type	master	tests-10122023
coverage	68.8 %	68.8 %
go-binary-size	5.8k KB	5.9k KB +
go-mod-dependencies	28	29 +
go-sec-issues	6	6
build-time	3 sec	4 sec +
unit-test-run-time	103 sec	18 sec -

Generated by Cover It Up.
View full report https://coveritup.app/kevincobain2000/gobrew

github-actions · 2023-12-11T12:28:24Z

Summary CoverItUp: kevincobain2000/gobrew

Type	master	tests-10122023
coverage	68.8 %	68.8 %
go-binary-size	5.8k KB	5.9k KB +
go-mod-dependencies	28	29 +
go-sec-issues	6	6
build-time	3 sec	3 sec
unit-test-run-time	103 sec	19 sec -

Generated by Cover It Up.
View full report https://coveritup.app/kevincobain2000/gobrew

juev · 2023-12-11T12:33:44Z

On Windows we had a problem with tests.
The uploaded files were blocked by the main go process, which prevented the temporary directory from being cleaned up in a timely manner. Because of this, certain special effects arose.
Why not waste time solving this problem while I disabled tests on Windows, as was the case before.

juev · 2023-12-11T13:12:12Z

Interesting question. Is it necessary to rewrite the history of the comedians to make the story cleaner? And did the changelog contain only the necessary information?

kevincobain2000

woah

juev · 2023-12-12T06:04:54Z

In this MR I also changed the client to work with http. I returned it back so as not to break the work via proxy.

github-actions · 2023-12-12T06:05:14Z

Summary CoverItUp: kevincobain2000/gobrew

Type	master	tests-10122023
coverage	68.8 %	68.7 % -
go-binary-size	5.8k KB	5.9k KB +
go-mod-dependencies	28	29 +
go-sec-issues	6	6
build-time	3 sec	3 sec
unit-test-run-time	101 sec	18 sec -

Generated by Cover It Up.
View full report https://coveritup.app/kevincobain2000/gobrew

* origin/master: work behind proxy work behind proxy

github-actions · 2023-12-12T06:11:44Z

Summary CoverItUp: kevincobain2000/gobrew

Type	master	tests-10122023
coverage	68.8 %	68.7 % -
go-binary-size	5.8k KB	5.9k KB +
go-mod-dependencies	28	29 +
go-sec-issues	6	6
build-time	3 sec	4 sec +
unit-test-run-time	101 sec	19 sec -

Generated by Cover It Up.
View full report https://coveritup.app/kevincobain2000/gobrew

kevincobain2000 · 2023-12-12T06:12:57Z

In this MR I also changed the client to work with http. I returned it back so as not to break the work via proxy.

Got it, thanks! No worries.

github-actions · 2023-12-12T06:23:47Z

Summary CoverItUp: kevincobain2000/gobrew

Type	master	tests-10122023
coverage	68.8 %	68.7 % -
go-binary-size	5.8k KB	5.9k KB +
go-mod-dependencies	28	29 +
go-sec-issues	6	6
build-time	3 sec	3 sec
unit-test-run-time	101 sec	19 sec -

Generated by Cover It Up.
View full report https://coveritup.app/kevincobain2000/gobrew

github-actions · 2023-12-12T06:26:03Z

Summary CoverItUp: kevincobain2000/gobrew

Type	master	tests-10122023
coverage	68.8 %	68.7 % -
go-binary-size	5.8k KB	5.9k KB +
go-mod-dependencies	28	29 +
go-sec-issues	6	6
build-time	3 sec	4 sec +
unit-test-run-time	101 sec	19 sec -

Generated by Cover It Up.
View full report https://coveritup.app/kevincobain2000/gobrew

kevincobain2000 · 2023-12-13T03:16:40Z

Will push new tag at night

kevincobain2000 · 2023-12-14T03:11:40Z

In this MR I also changed the client to work with http. I returned it back so as not to break the work via proxy.

Pushed to v1.10.5

Tested behind proxy too, works as intended.

juev added 8 commits December 10, 2023 17:24

feat: update library versions

62a1eb0

feat: do not use default http client on download with progress

8fb3b9e

fix: downloadAndExtract function

e2b2820

feat: add test for extract

c0abcb6

feat: add test for doRequest

b6519ed

feat: draft test for downloadAndExtract

34077fe

feat: draft test for DownloadWithProgress

86845dd

fix: tests for DownloadWithProgress and downloadAndExtract

e9ff7bd

juev requested a review from kevincobain2000 as a code owner December 11, 2023 09:31

juev force-pushed the tests-10122023 branch from 3ace28d to e200c24 Compare December 11, 2023 09:36

feat: add gobrew config

b7943a4

juev force-pushed the tests-10122023 branch from e200c24 to b7943a4 Compare December 11, 2023 09:42

fix: do not run tests in parallel

0a79aec

fix: run tests in bash shell

2bdd253

fix: add error message for close stream and file

7fe268f

fix: close file without defer

8d1c45f

fix: trying to not clean download dir

23f722d

juev added 3 commits December 11, 2023 15:23

Revert "fix: close file without defer"

6b8b377

This reverts commit 8d1c45f.

feat: cleanup downloads dir after extract

dc184e1

feat: remove windows from tests because issue with cleanup TmpDir

ced134e

feat: run tests in parallel again

eb3d558

kevincobain2000 approved these changes Dec 12, 2023

View reviewed changes

fix: use defaultClient for proxy

6498b3d

juev mentioned this pull request Dec 12, 2023

Improve golang-tags.json #168

Closed

Merge remote-tracking branch 'origin/master' into tests-10122023

0307901

* origin/master: work behind proxy work behind proxy

feat: use config struct in gobrew

ad444c1

fix: rename const to not use package name

9f16da7

kevincobain2000 approved these changes Dec 13, 2023

View reviewed changes

kevincobain2000 merged commit 9555cde into master Dec 13, 2023
14 checks passed

kevincobain2000 deleted the tests-10122023 branch December 13, 2023 01:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Tests 10122023 #167

Tests 10122023 #167

juev commented Dec 11, 2023

github-actions bot commented Dec 11, 2023

github-actions bot commented Dec 11, 2023

github-actions bot commented Dec 11, 2023

juev commented Dec 11, 2023

juev commented Dec 11, 2023

github-actions bot commented Dec 11, 2023

github-actions bot commented Dec 11, 2023

github-actions bot commented Dec 11, 2023

github-actions bot commented Dec 11, 2023

github-actions bot commented Dec 11, 2023

github-actions bot commented Dec 11, 2023

github-actions bot commented Dec 11, 2023

juev commented Dec 11, 2023

juev commented Dec 11, 2023

kevincobain2000 left a comment

juev commented Dec 12, 2023

github-actions bot commented Dec 12, 2023

github-actions bot commented Dec 12, 2023

kevincobain2000 commented Dec 12, 2023

github-actions bot commented Dec 12, 2023

github-actions bot commented Dec 12, 2023

kevincobain2000 commented Dec 13, 2023

kevincobain2000 commented Dec 14, 2023

Tests 10122023 #167

Tests 10122023 #167

Conversation

juev commented Dec 11, 2023

github-actions bot commented Dec 11, 2023

Summary CoverItUp: kevincobain2000/gobrew

github-actions bot commented Dec 11, 2023

Summary CoverItUp: kevincobain2000/gobrew

github-actions bot commented Dec 11, 2023

Summary CoverItUp: kevincobain2000/gobrew

juev commented Dec 11, 2023

juev commented Dec 11, 2023

github-actions bot commented Dec 11, 2023

Summary CoverItUp: kevincobain2000/gobrew

github-actions bot commented Dec 11, 2023

Summary CoverItUp: kevincobain2000/gobrew

github-actions bot commented Dec 11, 2023

Summary CoverItUp: kevincobain2000/gobrew

github-actions bot commented Dec 11, 2023

Summary CoverItUp: kevincobain2000/gobrew

github-actions bot commented Dec 11, 2023

Summary CoverItUp: kevincobain2000/gobrew

github-actions bot commented Dec 11, 2023

Summary CoverItUp: kevincobain2000/gobrew

github-actions bot commented Dec 11, 2023

Summary CoverItUp: kevincobain2000/gobrew

juev commented Dec 11, 2023

juev commented Dec 11, 2023

kevincobain2000 left a comment

Choose a reason for hiding this comment

juev commented Dec 12, 2023

github-actions bot commented Dec 12, 2023

Summary CoverItUp: kevincobain2000/gobrew

github-actions bot commented Dec 12, 2023

Summary CoverItUp: kevincobain2000/gobrew

kevincobain2000 commented Dec 12, 2023

github-actions bot commented Dec 12, 2023

Summary CoverItUp: kevincobain2000/gobrew

github-actions bot commented Dec 12, 2023

Summary CoverItUp: kevincobain2000/gobrew

kevincobain2000 commented Dec 13, 2023

kevincobain2000 commented Dec 14, 2023