DCH patch #416
Merged
DCH patch #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Which "optional" tag should one use? |
Thanks, I forgot. I have edited the release note to add it |
andresailer
reviewed
Dec 16, 2024
lopezzot
reviewed
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
useG4TTtag in the detector section.ENDRELEASENOTES
Hi,
After the patch I did for Geant4 twisted tube, it seems there is still an error when shooting exactly at theta 90 degrees. While this bug is being fixed, I implemented an alternative shape. Original twisted tube shape can be used if optional tag is added within the detector section.
The change is transparent to the user, so I did not increase the version number of the detector, what do you think?