Proposal 114: Add support for multiple API versions to the agent #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the proposal to add support for multiple API versions to the agent to make it backwards compatible. Resolves keylime#114 Signed-off-by: Anderson Toshiyuki Sasaki <[email protected]>
ansasaki
requested review from
mpeters,
galmasi,
maugustosilva,
THS-on and
aplanas
|
Generally LGTM. Especially for the push model having the We already give the verifier the supported agent API version via the tenant, so we then need to implement some logic in the tenant to find the latest version supported by both. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the proposal to add support for multiple API versions to the agent to make it backwards compatible.
Resolves #114