refactor: Add KeymanSiteEnvironment #12
Draft
+83
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darcywong00
commented
Dec 13, 2023
| $props = get_class_vars($class); | ||
| var_dump($props); | ||
| } | ||
| } |
There was a problem hiding this comment.
Looking ahead to refactoring
and
Will we want additional functions to
- unset a property
- return a boolean if the env var is
''?
There was a problem hiding this comment.
- unset a property
I'd prefer to rewrite how that particular function works. It's suboptimal at present.
- return a boolean if the env var is
''?
No, if the env var is unsset, then the property value should be NULL (testable with is_null, isset, isempty etc).
There was a problem hiding this comment.
No, if the env var is unsset, then the property value should be NULL ...
I meant for 2. to check when vars are initialized to ''
darcywong00
commented
Dec 14, 2023
_common/KeymanSiteEnvironment.php
Outdated
| $props = get_class_vars($class); | ||
| foreach($props as $name => $value) { | ||
| if (isset($env[$name])) { | ||
| self::$instance->$name = $env[$name]; |
There was a problem hiding this comment.
Back to draft since this line is giving me errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses this point from keymnapp/keyman.com#403
TODO: Refactor KeymanHosts?