Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix file deletion #4949

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix file deletion #4949

wants to merge 1 commit into from

Conversation

myadzel
Copy link

@myadzel myadzel commented Jul 25, 2019

Fixes issue #4946.

@myadzel myadzel changed the title fix file deletion #4946 fix file deletion Jul 25, 2019
@laurenskling
Copy link
Contributor

Could you please guide us through your changes?

@myadzel
Copy link
Author

myadzel commented Aug 28, 2019

I just corrected the behavior of the script according to the code that someone had written earlier.

  1. The storage.removeFile interface assumes the presence of the callback function, it is added. But the deletion method passes an empty function so as not to change the logic of storage.removeFile.

  2. The value of the value variable in the updateItem method is always an empty string at deletion.

  3. Method utils.defer(callback) is called later (by code) in case of deleting a file, so it is redundant and causes an error.

  4. Also added is the deletion of the file before uploading a new one (implementation of the file replacement, which also did not work before).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants