Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metadata structures and sets to IM and SDMX-ML reader #152

Merged
merged 103 commits into from
Jan 10, 2024

Conversation

khaeru
Copy link
Owner

@khaeru khaeru commented Dec 28, 2023

This adds coverage of some IM classes previously missing, particularly from §7: meta data structures and metadata sets; and reading these from SDMX-ML 2.1 and 3.0.

PR checklist

  • Checks all ✅
  • Update documentation
  • Update doc/whatsnew.rst

@khaeru khaeru added enh Enhancements & new features xml SDMX-ML format reader Read file formats defined by the SDMX standards labels Dec 28, 2023
@khaeru khaeru self-assigned this Dec 28, 2023
Copy link

codecov bot commented Dec 28, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (83ec5db) 98.36% compared to head (577c7f7) 96.35%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #152      +/-   ##
==========================================
- Coverage   98.36%   96.35%   -2.01%     
==========================================
  Files          87       87              
  Lines        6480     6916     +436     
==========================================
+ Hits         6374     6664     +290     
- Misses        106      252     +146     
Files Coverage Δ
sdmx/format/xml/common.py 100.00% <100.00%> (ø)
sdmx/format/xml/v21.py 100.00% <ø> (ø)
sdmx/format/xml/v30.py 100.00% <ø> (ø)
sdmx/message.py 100.00% <100.00%> (ø)
sdmx/model/common.py 99.90% <100.00%> (+<0.01%) ⬆️
sdmx/model/v21.py 100.00% <100.00%> (ø)
sdmx/model/v30.py 100.00% <100.00%> (ø)
sdmx/reader/xml/v30.py 95.23% <100.00%> (+0.28%) ⬆️
sdmx/rest.py 100.00% <ø> (ø)
sdmx/source/__init__.py 100.00% <ø> (ø)
... and 9 more

... and 16 files with indirect coverage changes

@khaeru khaeru changed the title Extend IM and SDMX-ML reader Add metadata structures and sets to IM and SDMX-ML reader Jan 10, 2024
@khaeru khaeru merged commit f137e51 into main Jan 10, 2024
20 checks passed
@khaeru khaeru deleted the enh/reader-xml-2023-W52 branch November 13, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enh Enhancements & new features reader Read file formats defined by the SDMX standards xml SDMX-ML format
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement MetadataSet, MetadataStructureDefinition, etc.
1 participant