Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confirm support for Python 3.13 and drop 3.8 #195

Merged
merged 8 commits into from
Oct 15, 2024
Merged

Confirm support for Python 3.13 and drop 3.8 #195

merged 8 commits into from
Oct 15, 2024

Conversation

khaeru
Copy link
Owner

@khaeru khaeru commented Sep 25, 2024

Python 3.13 will be released 2024-10-01 07. This PR is to:

  • Check/confirm that sdmx is compatible with the new version. This includes:
  • Drop support for Python 3.8, which will reach end-of-life (no more updates, even security updates) "approximately [during, before, or after] October 2024" per PEP 569.
    • Remove any code marked as for Python 3.8 compatibility only. Depending on these changes, part or all of the functionality may remain usable with Python 3.8 if users have extreme need.
    • Make any general clean-ups or improvements possible with features available from Python 3.9.
      • Type hint using standard collections, e.g. list[str] instead of from typing import List/List[str].

@khaeru khaeru self-assigned this Sep 25, 2024
@khaeru khaeru added the enh Enhancements & new features label Sep 25, 2024
Copy link

codecov bot commented Oct 15, 2024

Codecov Report

Attention: Patch coverage is 99.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 97.90%. Comparing base (5256723) to head (6f113ca).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
sdmx/tests/test_client.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #195      +/-   ##
==========================================
- Coverage   98.92%   97.90%   -1.03%     
==========================================
  Files          97       97              
  Lines        7839     7841       +2     
==========================================
- Hits         7755     7677      -78     
- Misses         84      164      +80     
Files with missing lines Coverage Δ
sdmx/client.py 93.98% <100.00%> (-3.83%) ⬇️
sdmx/dictlike.py 97.87% <100.00%> (ø)
sdmx/format/__init__.py 100.00% <100.00%> (ø)
sdmx/format/xml/common.py 100.00% <100.00%> (ø)
sdmx/message.py 100.00% <100.00%> (ø)
sdmx/model/__init__.py 100.00% <100.00%> (ø)
sdmx/model/common.py 99.90% <100.00%> (ø)
sdmx/model/internationalstring.py 100.00% <100.00%> (ø)
sdmx/model/v21.py 100.00% <100.00%> (ø)
sdmx/model/v30.py 100.00% <100.00%> (ø)
... and 24 more

... and 14 files with indirect coverage changes

@khaeru khaeru merged commit e80f9e6 into main Oct 15, 2024
20 checks passed
@khaeru khaeru deleted the python-3.13 branch November 13, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enh Enhancements & new features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant