forked from HL7/fhir
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Genomic study resource #1
Open
khalifa-aly
wants to merge
115
commits into
khalifa-aly:genomicStudyResource
Choose a base branch
from
HL7:genomicStudyResource
base: genomicStudyResource
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Genomic study resource #1
khalifa-aly
wants to merge
115
commits into
khalifa-aly:genomicStudyResource
from
HL7:genomicStudyResource
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Updated bundle-ImagingSelection-search-params.xml to match oid to id update
Remove Immunization.recorded
FHIR-29673 - Fixed display names for SNOMED codes in gender identity value set
Add ServiceRequest to Immunization.basedOn
Added Patient and RelatedPerson to Immunization.performer.actor
Updated wording of the search description to include "individuals"
Related to already applied FHIR-33021
fix a build warning
Imaging selection Updates
J# 37660 EvidenceVariable element change
MolecularSequence.relative.ordinalPosition and *.sequenceRange
FHIR-37664, adding two new elements
MolecularSequence.relative.reference and others
FHIR-34301, FHIR-36061 and FHIR-32773
MolecularSequence.relative.reference and others
Further modeling suggests method 0..* CodeableConcept is functionally a modifier of the type element in definitionByTypeAndValue.type[x] and allows simplification to definitionByTypeAndValue.type 1..1 CodeableConcept because method can express necessary modifiers of how the type is determined. This leads to an overall simplification of the Resource (typeReference and typeId are no longer needed) and the proposed disposition is now to: Delete EvidenceVariable.characteristic.method Add EvidenceVariable.characteristic.definitionByTypeAndValue.method 0..* CodeableConcept Change EvidenceVariiable.characteristic.definitionByTypeAndValue.type[x] to simply type 1..1 CodeableConcept Further modeling was done with an example of "Coagulopathy as serious adverse event" modeled in 5 variations. The set of examples can be found at https://fevir.net/resources/Project/52195 and the preferred/optimal version is at https://fevir.net/resources/EvidenceVariable/52198 There are further changes that can simplify the EvidenceVariable Resource (in addition to the prior comment) including (1) moving the device element from EvidenceVariable.characteristic to EvidenceVariable.characteristic.definitionByTypeAndValue and (2) deleting the EvidenceVariable.characteristic.groupMeasure element as it can be handled as a method by include the value set in the CharacteristicMethod value set. This leads to an even better overall simplification of the Resource and the proposed disposition is now to: Delete EvidenceVariable.characteristic.method Delete EvidenceVariable.characteristic.device Delete EvidenceVariable.characteristic.groupMeasure Change EvidenceVariable.characteristic.definitionByTypeAndValue.type[x] to simply type 1..1 CodeableConcept Add EvidenceVariable.characteristic.definitionByTypeAndValue.method 0..* CodeableConcept with Preferred binding to DefinitionMethod value set Add EvidenceVariable.characteristic.definitionByTypeAndValue.device 0..1 Reference(Device | DeviceMetric) Create a DefinitionMethod value set by combining: 2 terms from the CharacteristicMethod value set http://build.fhir.org/valueset-characteristic-method.html 6 terms from the GroupMeasure value set http://build.fhir.org/valueset-group-measure.html additional terms for commonly used source vocabularies for adverse event definitions (e.g. MedDRA (23.0))
Gg 202207 conceptmap2
J# 37715 preapplied as amended in the comments
Rik meddef 9
Fix typos
Update text on ICD, NDF-RT and MED-RT pages
Add missing paren
FHIR-35800 and 31601 Update text on ICD, NDF-RT and MED-RT pages
Corrected reference to DocRef that should have been DiagRpt
Molecular sequence resource
ImagingSelection July updates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HL7 FHIR Pull Request
Note: No pull requests will be accepted against
./source
unless logged in the HL7 Jira issue tracker.If you made changes to any files within
./source
please indicate the Jira tracker number this pull request is associated with:Description
Please describe your pull request here.