Support Azure OpenAI API endpoint as Chat Provider #1048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| api_key=openai_api_key, | ||
| base_url=api_base_url, | ||
| ) | ||
| if api_base_url and "openai.azure.com" in api_base_url: |
Check failure
Code scanning / CodeQL
Incomplete URL substring sanitization High
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix AI 6 days ago
To fix the problem, we need to ensure that the api_base_url is properly parsed and its hostname is checked to confirm it matches the expected domain. This can be achieved by using the urlparse function from the urllib.parse module to extract the hostname and then verifying that it ends with the expected domain.
- Parse the
api_base_urlusingurlparse. - Extract the hostname from the parsed URL.
- Check if the hostname ends with the expected domain ".openai.azure.com".
Suggested changeset
1
src/khoj/processor/conversation/openai/utils.py
| @@ -22,2 +22,3 @@ | ||
| from khoj.utils.helpers import get_chat_usage_metrics, is_promptrace_enabled | ||
| from urllib.parse import urlparse | ||
|
|
||
| @@ -53,8 +54,10 @@ | ||
| if not client: | ||
| if api_base_url and "openai.azure.com" in api_base_url: | ||
| client = openai.AzureOpenAI( | ||
| api_key=openai_api_key, | ||
| azure_endpoint=api_base_url, | ||
| api_version="2024-10-21", | ||
| ) | ||
| if api_base_url: | ||
| parsed_url = urlparse(api_base_url) | ||
| if parsed_url.hostname and parsed_url.hostname.endswith("openai.azure.com"): | ||
| client = openai.AzureOpenAI( | ||
| api_key=openai_api_key, | ||
| azure_endpoint=api_base_url, | ||
| api_version="2024-10-21", | ||
| ) | ||
| else: |
Copilot is powered by AI and may make mistakes. Always verify output.
Unable to commit as this autofix suggestion is now outdated
debanjum
force-pushed
the
support-azure-openai-api-endpoint
branch
from
e057838 to
275d70e
Compare
debanjum
force-pushed
the
support-azure-openai-api-endpoint
branch
from
275d70e to
f6948a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenAI chat models deployed on Azure are (ironically) not OpenAI API compatible endpoints.
This change enables using OpenAI chat models deployed on Azure with Khoj.