Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.67.x-blue] AF-2949 : Remove unused Tomcat builds (#1409) #1412

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

Rikkola
Copy link
Member

@Rikkola Rikkola commented Jan 4, 2024

(cherry picked from commit acbb766)

https://issues.redhat.com/browse/AF-2949

How to replicate CI configuration locally?

Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.

build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.

How to retest this PR or trigger a specific build:
  • a pull request please add comment: Jenkins retest this

  • a full downstream build please add comment: Jenkins run fdb

  • a compile downstream build please add comment: Jenkins run cdb

  • a full production downstream build please add comment: Jenkins execute product fdb

  • an upstream build please add comment: Jenkins run upstream

How to backport a pull request to a different branch?

In order to automatically create a backporting pull request please add one or more labels having the following format backport-<branch-name>, where <branch-name> is the name of the branch where the pull request must be backported to (e.g., backport-7.67.x to backport the original PR to the 7.67.x branch).

NOTE: backporting is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.

Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.

If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

@Rikkola Rikkola changed the title AF-2949 : Remove unused Tomcat builds (#1409) [7.67.x-blue] AF-2949 : Remove unused Tomcat builds (#1409) Jan 4, 2024
@Rikkola
Copy link
Member Author

Rikkola commented Jan 4, 2024

Jenkins run fdb

1 similar comment
@Rikkola
Copy link
Member Author

Rikkola commented Jan 8, 2024

Jenkins run fdb

@caponetto caponetto self-requested a review January 9, 2024 13:22
@tomasdavidorg
Copy link
Contributor

tomasdavidorg commented Jan 10, 2024

Hi @Rikkola, I found two files where the TomCat was not removed in TOMCAT-7.67.x-blue brach (TOMCAT-7.67.x seems to be ok):
uberfire-extensions/uberfire-security/uberfire-security-management/uberfire-security-management-tomcat/pom.xml
and another occurency is in
uberfire-showcase/showcase-distribution-wars/pom.xml.

@mareknovotny
Copy link
Member

could you please do those additional changes identified at #1412 (comment) ? @Rikkola

@Rikkola
Copy link
Member Author

Rikkola commented Jan 11, 2024

Sure, I will see what is up.

@Rikkola
Copy link
Member Author

Rikkola commented Jan 11, 2024

Jenkins run fdb

Copy link

sonarcloud bot commented Jan 11, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@Rikkola
Copy link
Member Author

Rikkola commented Jan 12, 2024

Jenkins run fdb

@Rikkola
Copy link
Member Author

Rikkola commented Jan 24, 2024

Jenkins run cdb

@mareknovotny
Copy link
Member

mareknovotny commented Jan 25, 2024

there is again concurrency problem for embedded Wildfly server
Caused by: org.jboss.as.cli.CommandLineException: java.util.concurrent.ExecutionException: org.jboss.as.cli.CommandLineException: Cannot start embedded server

As FDB passed we can ignore it

@mareknovotny mareknovotny merged commit 622f00f into kiegroup:7.67.x-blue Jan 25, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants