forked from apache/incubator-kie-drools
-
Notifications
You must be signed in to change notification settings - Fork 31
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[DROOLS-7578] Evaluate Impact analysis for ansible integration rules (a…
…pache#5594) - Introduced DeleteSpecificFactAction for retract_fact - Add a test case
- Loading branch information
1 parent
444f9f9
commit 09dbd7f
Showing
5 changed files
with
199 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
78 changes: 78 additions & 0 deletions
78
...c/test/java/org/drools/impact/analysis/integrationtests/DeleteSpecificFactActionTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,78 @@ | ||
| /** | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * <p> | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * <p> | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
| package org.drools.impact.analysis.integrationtests; | ||
|
|
||
| import java.util.List; | ||
|
|
||
| import org.drools.impact.analysis.graph.Graph; | ||
| import org.drools.impact.analysis.graph.ModelToGraphConverter; | ||
| import org.drools.impact.analysis.graph.ReactivityType; | ||
| import org.drools.impact.analysis.integrationtests.domain.Address; | ||
| import org.drools.impact.analysis.integrationtests.domain.Person; | ||
| import org.drools.impact.analysis.model.AnalysisModel; | ||
| import org.drools.impact.analysis.model.right.ConsequenceAction; | ||
| import org.drools.impact.analysis.model.right.DeleteSpecificFactAction; | ||
| import org.drools.impact.analysis.model.right.SpecificProperty; | ||
| import org.drools.impact.analysis.parser.ModelBuilder; | ||
| import org.junit.Test; | ||
|
|
||
| /** | ||
| * This test is to verify that DeleteSpecificFactAction can be handled correctly. | ||
| * DeleteSpecificFactAction cannot be created by ModelBuilder from DRL, so we programmatically add it to the model. | ||
| */ | ||
| public class DeleteSpecificFactActionTest extends AbstractGraphTest { | ||
|
|
||
| @Test | ||
| public void insertDeleteSpecific() { | ||
| String str = | ||
| "package mypkg;\n" + | ||
| "import " + Person.class.getCanonicalName() + ";" + | ||
| "import " + Address.class.getCanonicalName() + ";" + | ||
| "rule R1 when\n" + | ||
| " $p : Person(name == \"John\")\n" + | ||
| "then\n" + | ||
| " Address address = new Address();" + | ||
| " address.setStreet(\"ABC\");" + | ||
| " insert(address);" + | ||
| "end\n" + | ||
| "rule R2 when\n" + | ||
| " $p : Person(name == \"Paul\")\n" + | ||
| "then\n" + | ||
| // Here, delete a fact with street == "ABC" (ansible-rulebook can do it) | ||
| "end\n" + | ||
| "rule R3 when\n" + | ||
| " $a : Address(street == \"ABC\")\n" + | ||
| "then\n" + | ||
| "end\n"; | ||
|
|
||
| AnalysisModel analysisModel = new ModelBuilder().build(str); | ||
|
|
||
| // Tweak analysisModel because DeleteSpecificFactAction cannot be created by ModelBuilder | ||
| List<ConsequenceAction> actions = analysisModel.getPackages().get(0).getRules().get(1).getRhs().getActions(); | ||
| DeleteSpecificFactAction deleteSpecificFactAction = new DeleteSpecificFactAction(Address.class); | ||
| deleteSpecificFactAction.addSpecificProperty(new SpecificProperty("street", "ABC")); | ||
| actions.add(deleteSpecificFactAction); | ||
|
|
||
| ModelToGraphConverter converter = new ModelToGraphConverter(); | ||
| Graph graph = converter.toGraph(analysisModel); | ||
|
|
||
| assertLink(graph, "mypkg.R1", "mypkg.R3", ReactivityType.POSITIVE); | ||
| assertLink(graph, "mypkg.R2", "mypkg.R3", ReactivityType.NEGATIVE); | ||
| } | ||
| } |
53 changes: 53 additions & 0 deletions
53
...-model/src/main/java/org/drools/impact/analysis/model/right/DeleteSpecificFactAction.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,53 @@ | ||
| /** | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * <p> | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * <p> | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
| package org.drools.impact.analysis.model.right; | ||
|
|
||
| import java.util.ArrayList; | ||
| import java.util.List; | ||
|
|
||
| /** | ||
| * This class represents a delete action for a specific fact. | ||
| * Use this action when you know the fact's properties to be deleted, assuming other facts of the same class still | ||
| * exist in the working memory. (Usually, you don't know the fact's properties) | ||
| * This action is introduced to support retract_fact action in drools-ansible-rulebook-integration-visualization. | ||
| */ | ||
| public class DeleteSpecificFactAction extends ConsequenceAction { | ||
|
|
||
| private final List<SpecificProperty> specificProperties = new ArrayList<>(); | ||
|
|
||
| public DeleteSpecificFactAction(Class<?> actionClass) { | ||
| super(Type.DELETE, actionClass); | ||
| } | ||
|
|
||
| public List<SpecificProperty> getSpecificProperties() { | ||
| return specificProperties; | ||
| } | ||
|
|
||
| public void addSpecificProperty(SpecificProperty specificProperty) { | ||
| specificProperties.add(specificProperty); | ||
| } | ||
|
|
||
| @Override | ||
| public String toString() { | ||
| return "DeleteSpecificFactAction{" + | ||
| "actionClass=" + actionClass + | ||
| ", specificProperties=" + specificProperties + | ||
| '}'; | ||
| } | ||
| } |
38 changes: 38 additions & 0 deletions
38
...analysis-model/src/main/java/org/drools/impact/analysis/model/right/SpecificProperty.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| /** | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * <p> | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * <p> | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
| package org.drools.impact.analysis.model.right; | ||
|
|
||
| public class SpecificProperty extends ModifiedProperty { | ||
|
|
||
| public SpecificProperty(String property) { | ||
| this(property, null); | ||
| } | ||
|
|
||
| public SpecificProperty(String property, Object value) { | ||
| super(property, value); | ||
| } | ||
|
|
||
| @Override | ||
| public String toString() { | ||
| return "SpecificProperty{" + | ||
| "property='" + property + '\'' + | ||
| ", value=" + value + | ||
| '}'; | ||
| } | ||
| } |