Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-ISSUE: fix condition error in upstream-sync and main-sync workflows #1555

Conversation

fantonangeli
Copy link
Contributor

@fantonangeli fantonangeli commented May 3, 2024

@fantonangeli fantonangeli changed the title NO-ISSUE: fix condition error in upstream sync NO-ISSUE: fix condition error in upstream-sync and main-sync workflows May 4, 2024
@fantonangeli
Copy link
Contributor Author

@rgdoliveira @ricardozanini, I tested this PR with my kogito-examples fork on GH and you can consider this as ready to review.

Copy link
Member

@rgdoliveira rgdoliveira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made some comments, but in overall it looks good

.ci/actions/main-sync/action.yml Outdated Show resolved Hide resolved
.ci/actions/upstream-sync/action.yml Outdated Show resolved Hide resolved
.ci/actions/main-sync/action.yml Outdated Show resolved Hide resolved
@mareknovotny mareknovotny merged commit e0fa918 into kiegroup:main Jun 27, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants