Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[9.100.x-prod][SRVLOGIC-325] use KogitoVersion variable for org.apache.kie.sonataflow:sonataflow-quarkus-devui version #28

Merged

Conversation

rgdoliveira
Copy link
Member

@rgdoliveira rgdoliveira commented Jun 10, 2024

Copy link

@treblereel treblereel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works for me. But I removed frontend-maven-plugin at sonataflow-quarkus-devui/pom.xml to make it compile. I think it's my local issue, not related with this PR

@rgdoliveira rgdoliveira merged commit f308d59 into kiegroup:9.100.x-prod Jun 11, 2024
1 of 5 checks passed
@tomasdavidorg
Copy link

It works for me. But I removed frontend-maven-plugin at sonataflow-quarkus-devui/pom.xml to make it compile. I think it's my local issue, not related with this PR

I have the same error locally. Is there any jira for this or should I create one?

@treblereel
Copy link

@tomasdavidorg yeap, I think you can create an issue

@rgdoliveira
Copy link
Member Author

Just some context related to the OSL product.

The frontend-maven-plugin is added in sonataflow-quarkus-devui/pom.xml just in midstream (product), because we need to build (productize) the Quarkus Dev UI. The build is done via root pom.xml created on midstream repository only which in the end invokes the sonataflow-quarkus-devui modules.

For building the kn workflow binary in the product, we use Brew system and we are doing an RPM build. We have a spec file in dist-git which invokes the Kn workflow Makefile (packages/kn-plugin-workflow/Makefile). For better explanation please check Jira SRVLOGIC-325.

So if a Jira would be created, I believe it should be just for the product (SRVLOGIC) as we have those differences from midstream and upstream

(cc @mareknovotny)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants