[SRVLOGIC-287] Recreate Operator/Bundle files dropped from upstream in midstream #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mareknovotny
approved these changes
Apr 26, 2024
rgdoliveira
commented
May 13, 2024
| - schema_version: 1 | ||
| name: "operator-builder" | ||
| version: "1.32.0" | ||
| from: "registry.access.redhat.com/ubi8/go-toolset:1.20.12" |
There was a problem hiding this comment.
@ricardozanini as we talked in the meeting today, I bumped to 1.20.12
ricardozanini
approved these changes
May 13, 2024
| @@ -0,0 +1,23 @@ | |||
| apiVersion: v1 | |||
| data: | |||
| DEFAULT_BUILDER_RESOURCE_NAME: Dockerfile | |||
There was a problem hiding this comment.
I think I've removed this line, but we can fix this if after this PR gets merged. Ideally, the logic-* files should be copied from the upstream part and apply a template overriding prod unique info.
wmedvede
approved these changes
May 14, 2024
|
@rgdoliveira e2e failing test might be related with the fact that the swf-builder image is now updated to quarkus 3.8.4. So, maybe we need to:
Current persistence related failure. Summarizing 1 Failure: |
Files/Folders were renamed in midstream to: - Makefile.osl -> Makefile.prod - bundle.osl -> bundle.prod - config/default/osl -> config/default/prod - config/manifests/osl -> config/manifests/prod - config/manager/osl/ -> config/manager/prod
Files/Folders were renamed in midstream to: - osl-image-prod.yaml -> prod-operator-image.yaml - osl-bundle-prod.yaml -> prod-bundle-image.yaml - images/modules/org.kie.kogito.osl.builder.prod -> images/modules/org.kie.kogito.prod.builder
|
@rgdoliveira greens! |
Merged
2 tasks
rgdoliveira
added a commit
that referenced
this pull request
May 15, 2024
…n midstream (#34) (#43) * Recreate Makefile osl and osl folders Files/Folders were renamed in midstream to: - Makefile.osl -> Makefile.prod - bundle.osl -> bundle.prod - config/default/osl -> config/default/prod - config/manifests/osl -> config/manifests/prod - config/manager/osl/ -> config/manager/prod * Recreate cekit descriptors and cachito prod module Files/Folders were renamed in midstream to: - osl-image-prod.yaml -> prod-operator-image.yaml - osl-bundle-prod.yaml -> prod-bundle-image.yaml - images/modules/org.kie.kogito.osl.builder.prod -> images/modules/org.kie.kogito.prod.builder * fix paths after folders renaming * set versions to 1.32.0 * recreate prod bundle module * use com.redhat.osl prefix for prod modules name * add missing headers * update go-toolset image to 1.20.12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
Motivation for the change:
Checklist
How to backport a pull request to a different branch?
In order to automatically create a backporting pull request please add one or more labels having the following format
backport-<branch-name>, where<branch-name>is the name of the branch where the pull request must be backported to (e.g.,backport-7.67.xto backport the original PR to the7.67.xbranch).Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.
If something goes wrong, the author will be notified and at this point a manual backporting is needed.