-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update supported arches for kn-workflow-cli-artifacts image #36
Conversation
c0305d1
to
735d9bb
Compare
As discussed on slack channel, the kn workflow rpm will be built for x86_64 and aarch64 only, IBM Z and P are not required. |
Thanks for approving it, I will just wait for the rpm part to be built and then I can merge this one (or change something if required) |
735d9bb
to
ac595d4
Compare
tar --transform='flags=r;s|kn-workflow-darwin-amd64|kn|' -zcf kn-workflow-macos-amd64.tar.gz kn-workflow-darwin-amd64 LICENSE | ||
tar --transform='flags=r;s|kn-workflow-darwin-arm64|kn|' -zcf kn-workflow-macos-arm64.tar.gz kn-workflow-darwin-arm64 LICENSE | ||
|
||
mkdir "${KN_WORK_DIR}/windows" && mv kn-workflow-windows-amd64.exe "${KN_WORK_DIR}/windows/kn.exe" && cp LICENSE "${KN_WORK_DIR}/windows/" && zip --quiet --junk-path - "${KN_WORK_DIR}/windows/*" > kn-workflow-windows-amd64.zip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The image is failing to build in this part related to Windows and it seems it is failing when invoking the zip
command.
@ricardozanini could you please take a look at it? I sent in slack the command to build the image with correct URL.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the error?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+ mkdir /opt/app-root/src/go/src/github.com/knative/client/windows
+ mv kn-workflow-windows-amd64.exe /opt/app-root/src/go/src/github.com/knative/client/windows/kn.exe
+ cp LICENSE /opt/app-root/src/go/src/github.com/knative/client/windows/
+ zip --quiet --junk-path - '/opt/app-root/src/go/src/github.com/knative/client/windows/*'
zip error: Nothing to do! (-)
Error: building at STEP "RUN sh -x /tmp/scripts/com.redhat.osl.cli.packager/install.sh": while running runtime: exit status 12
2024-06-03 18:55:32,012 tools.py:359 ERROR Command '['/usr/bin/podman', 'build', '--squash', '-t', 'openshift-serverless-1/logic-kn-workflow-cli-artifacts-rhel8:1.33.0', '-t', 'openshift-serverless-1/logic-kn-workflow-cli-artifacts-rhel8:latest', '--build-arg=KN_ARTIFACT_URL=http://download.devel.redhat.com/staging-cds/etera/test/kn-workflow-plugin/1/1.33/1.33.0-1/signed/', 'target/image']' returned non-zero exit status 12. Command stdout is 'None' with stderr 'None'
2024-06-03 18:55:32,012 cli.py:542 ERROR Could not run podman ['/usr/bin/podman', 'build', '--squash', '-t', 'openshift-serverless-1/logic-kn-workflow-cli-artifacts-rhel8:1.33.0', '-t', 'openshift-serverless-1/logic-kn-workflow-cli-artifacts-rhel8:latest', '--build-arg=KN_ARTIFACT_URL=http://download.devel.redhat.com/staging-cds/etera/test/kn-workflow-plugin/1/1.33/1.33.0-1/signed/', 'target/image']
Traceback (most recent call last):
File "/home/rguimara/cekit-4.11.0/lib64/python3.11/site-packages/cekit/tools.py", line 351, in run_wrapper
result = subprocess.run(
^^^^^^^^^^^^^^^
File "/usr/lib64/python3.11/subprocess.py", line 571, in run
raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command '['/usr/bin/podman', 'build', '--squash', '-t', 'openshift-serverless-1/logic-kn-workflow-cli-artifacts-rhel8:1.33.0', '-t', 'openshift-serverless-1/logic-kn-workflow-cli-artifacts-rhel8:latest', '--build-arg=KN_ARTIFACT_URL=http://download.devel.redhat.com/staging-cds/etera/test/kn-workflow-plugin/1/1.33/1.33.0-1/signed/', 'target/image']' returned non-zero exit status 12.
thanks, merging it. |
* update supported arches for kn-workflow-cli-artifacts image * set versions to 1.33.0 * fix indentation in images/osl-cli.yaml * fix LICENSE path in /tmp * add quiet to wget * fix zip command when creating windows zip * remove internal url from example
As discussed in slack channel, for kn cli we should only support amd64 and aarch64, IBM P/Z is not supported and there will be no rpm build of it.
Related PRs:
Checklist
How to backport a pull request to a different branch?
In order to automatically create a backporting pull request please add one or more labels having the following format
backport-<branch-name>
, where<branch-name>
is the name of the branch where the pull request must be backported to (e.g.,backport-7.67.x
to backport the original PR to the7.67.x
branch).Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.
If something goes wrong, the author will be notified and at this point a manual backporting is needed.