-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
set prod images version to 1.35 #90
Conversation
replaces: logic-operator-rhel8.v1.34.0 | ||
version: 0.0.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't be there version updated as well? Here is version 0.0.0 is this correct for this csv file
name: IMAGE_LOGIC_SWF_BUILDER | ||
- image: registry.redhat.io/openshift4/ose-kube-rbac-proxy@sha256:4564ca3dc5bac80d6faddaf94c817fbbc270698a9399d8a21ee1005d85ceda56 | ||
name: IMAGE_KUBE_RBAC_PROXY | ||
replaces: logic-operator-rhel8.v1.33.0 | ||
replaces: logic-operator-rhel8.v1.34.0 | ||
version: 0.0.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jakubschwan You mean like this?
version: 0.0.0 | |
version: 1.35.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be logic-operator-rhel8.v1.35.0
config/manifests/prod/bases/logic-operator-rhel8.clusterserviceversion.yaml
Outdated
Show resolved
Hide resolved
replaces: logic-operator-rhel8.v1.33.0 | ||
version: 0.0.0 | ||
replaces: logic-operator-rhel8.v1.34.0 | ||
version: logic-operator-rhel8.v1.35.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
following the rational in: bundle.prod/manifests/logic-operator-rhel8.clusterserviceversion.yaml
shouldn't this version number here be, version: 1.35.0 instead of version: logic-operator-rhel8.v1.35.0 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wmedvede you're right. The version is 1.35
. I just checked here https://github.com/kiegroup/kogito-serverless-operator/blob/9.101.x-prod/bundle.prod/manifests/logic-operator-rhel8.clusterserviceversion.yaml#L897
@rgdoliveira The fix I made in the CSV is from this branch, correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ricardozanini the fix you did for CSV was done in branch 9.101.x-prod and I just brought it to main branch.
The file @wmedvede mentioned bundle.prod/manifests/logic-operator-rhel8.clusterserviceversion.yaml
looks correct in 9.101.x-prod branch, see https://github.com/kiegroup/kogito-serverless-operator/blob/9.101.x-prod/bundle.prod/manifests/logic-operator-rhel8.clusterserviceversion.yaml#L897
But the other file config/manifests/prod/bases/logic-operator-rhel8.clusterserviceversion.yaml
in fact had version as 0.0.0
for the bundle respin we did for OSL 1.34, see https://github.com/kiegroup/kogito-serverless-operator/blob/9.101.x-prod/config/manifests/prod/bases/logic-operator-rhel8.clusterserviceversion.yaml#L287
As there was no issues during tests and it worked it the end, I suppose this second file was not really used in productization?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've just changed it to 1.35.0
config/manifests/prod/bases/logic-operator-rhel8.clusterserviceversion.yaml
Outdated
Show resolved
Hide resolved
1df7e86
to
81ed7a7
Compare
@ricardozanini @wmedvede @jakubschwan can we merge this one? |
Waiting for CI |
CI is green, merging... |
Description of the change:
Motivation for the change:
Checklist
How to backport a pull request to a different branch?
In order to automatically create a backporting pull request please add one or more labels having the following format
backport-<branch-name>
, where<branch-name>
is the name of the branch where the pull request must be backported to (e.g.,backport-7.67.x
to backport the original PR to the7.67.x
branch).Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.
If something goes wrong, the author will be notified and at this point a manual backporting is needed.