Start ngrok if the current listened port is not the expected one

[juherr]

For #51

[kilmajster]

First of all, big thanks for contributing! Code changes are fine to me, I put 2 small comments but they are more like ideas to discuss :)

[kilmajster]

maybe its a good idea to make this prefix (I mean onlyspringboot- part) configurable, or taking it from spring.application.name property with springboot- as a default value? wdyt?

[juherr]

Using spring.application.name is an excellent idea

[juherr]

Done

[kilmajster]

then this test could use some more serious values :)

[juherr]

I didn't want to make too much complexity in mocks.
But to be honest I was a bit lazy too.
Do you have any values you'd like?

[kilmajster]

I meant something like:

when(ngrokApiClient.startTunnel(eq(8080), eq("http"), anyString()))
        .thenReturn(ngrokTunnelsList.getTunnels().get(0));
when(ngrokApiClient.startTunnel(eq(8080), eq("https"), anyString()))
        .thenReturn(...

but you can leave it like this, because I got work in progress done in NgrokApiClient in order to cover full ngrok api, just need to add some tests so anyways I'll need to update this one :)

[juherr]

I will let you do better in the next step ;)

[juherr]

Fyi, I didn't make real-life tests, only unit tests with mocks.
How do you usually manage it?

[kilmajster]

Basically I don't have any particular way before making new release. I just test manually if new functionality works with dummy app, and when I touched some other part I test also that. Then github checks are testing if minimal configuration works with .github/test-app with real ngrok tunnels in containers of windows, macos, and linux and if yes I'm assuming that everything is ready

[juherr]

Ok, so feel free to ping me if something is going wrong with my changes :)

[kilmajster]

Hi, I made tests on real app and it turns out https is not a valid name for proto, so it was failing with HTTP 400. I spent a moment on figuring out how to start https tunnel, but after a few tests with postman, I found that after starting a tunnel via API it creates http and also https tunnel. Moreover https tunnel gets name that was used in the creation request, http tunnel name gets (http) sufix with space on the begining, that was not mentioned in any way in the documentation 🙄 so my conclusion is that ngrok treats https as a default for http tunneling.
Anyways I replaced second call of NgrokApiClient#startTunnel with search for tunnel by name, did some other polishing like version bump etc and released everything as 0.3.7 version

fyi, what I did - eb29737

:)

[juherr]

Awesome! I can't wait to test it.