docs: Add initial docs on how to use node local storage #51

rata · 2019-08-13T15:55:03Z

This adds basic documentation on how to use node local storage using
local persistent volumes in filesystem mode.

Other sections are mentioned, although empty for now, on other ways to
use it that we may want to expand later.

docs/advanced/node-local-storage.md

invidian

Added suggestions. The overall document seems all right.

docs/advanced/node-local-storage.md

rata · 2019-08-14T11:18:27Z

@pothos @invidian thanks a lot for the detailed review! And the commit suggestions!

I think it is much improved now (added all your suggestions :)), PTAL @pothos @invidian :)

invidian

Few more found.

docs/advanced/node-local-storage.md

surajssd

Few nits and suggestions. The document is helpful. But the last section can go into other doc or be totally removed IMO. With so many links and lot of text it is just confusing than of help to users.

docs/advanced/node-local-storage.md

surajssd · 2019-08-14T13:11:43Z

docs/advanced/node-local-storage.md

+[1]: https://github.com/kubernetes-sigs/sig-storage-local-static-provisioner/blob/master/docs/operations.md
+[2]: https://github.com/kubernetes-sigs/sig-storage-local-static-provisioner/blob/master/docs/faqs.md
+
+### Useful links


I am not sure if rest of this document should be here, rather than helping user it is just confusing user to follow lot of other links.

I would rather let this document be only something we support and have tried, tested and trusted.

Okay... But I think that is useful and I would prefer to have this somewhere, where do you suggest? Or you suggest to just drop this?

docs/advanced/node-local-storage.md

rata · 2019-09-02T17:15:24Z

@surajssd PTAL. I've addressed the all comments, except the ones I asked you something, and adapted to use /mnt/node-local-storage as path, as that was recently changed in master

kosyfrances

This is what I have reviewed for now, will continue another time.

docs/advanced/node-local-storage.md

kosyfrances · 2019-09-23T10:57:03Z

docs/advanced/node-local-storage.md

+```
+
+You can also connect to the pod and write to the volume which is mounted on
+`/usr/test-pod`, you will see in the host on `/mnt/node-local-storage`.


No you won't see it on the host, although if you delete the pod and a new one gets created, it will still have the same contents of the old pod.

I did a setup using this PR, but whatever I wrote to the pod on /usr/test-pod, did not show up on the host's /mnt/node-local-storage 😕 . So, I decided to try with a different directory. I created a /mnt/data directory on the host and it had the following permissions by default.

core@kosy-worker-worker-0 /mnt $ ls -l total 12 drwxr-xr-x. 2 root root 4096 Sep 23 09:59 data drwxr-xr-x. 3 root root 4096 Sep 23 07:33 node-local-storage

After creating the pv to use /mnt/data instead of node-local-storage, I wrote to the pod and saw the new file also in /mnt/data and noticed that the permissions on /mnt/data/ changed by itself to:

core@kosy-worker-worker-0 /mnt $ ls -ll total 12 drwxrwsr-x. 2 root bin 4096 Sep 23 10:15 data drwxr-xr-x. 3 root root 4096 Sep 23 07:33 node-local-storage

rata · 2019-09-27T15:44:43Z

Node local storage was moved back to /mnt in this PR #72 recently merged, so we need to adjust this doc to reflect that

invidian · 2020-01-06T15:33:29Z

@rata do you have time to take care of this PR?

rata · 2020-02-06T17:18:01Z

@invidian not really, and is kind of outdated now. I'll try to keep an eye on this during next week, but no promises :(

invidian · 2020-02-12T13:01:06Z

I'm taking a look into it to get it merged.

Dismissing my own review for others to review.

rata · 2020-02-12T16:17:49Z

docs/advanced/node-local-storage.md

+
+1. Lokomotive Kubernetes currently only exposes `/mnt/` to the kubelet, so only that
+directory can be used for node local storage. You can **manually** mount different
+devices on `/mnt/sda` or paths inside `/mnt` at your convenience.


This was not the case before self-hosted kubelet, as the pod didn't saw mounts inside mnt (see #73) Not sure if it is now possible with self-hosted kubelet

If' say remove the "You can manually mount different devices on /mnt/sda or paths inside /mnt at your convenience" but I'm failing to create a github suggestion for this, not sure why 🤦‍♂️

rata · 2020-02-12T16:20:21Z

IMHO, it looks fine besides the two open comments (the one I just posted and suraj comment from long ago).

Maybe we can oing and wait for suraj to comment again?

rata · 2020-02-12T16:25:46Z

docs/advanced/node-local-storage.md

+
+1. Lokomotive Kubernetes currently only exposes `/mnt/` to the kubelet, so only that
+directory can be used for node local storage. You can **manually** mount different
+devices on `/mnt/sda` or paths inside `/mnt` at your convenience.


If' say remove the "You can manually mount different devices on /mnt/sda or paths inside /mnt at your convenience" but I'm failing to create a github suggestion for this, not sure why 🤦‍♂️

rata · 2020-02-12T16:28:25Z

docs/advanced/node-local-storage.md

+
+1. You can share the volume in different PVs if you create a sub-directory per
+PV, bind mount each of them and only expose the subdirectories. It is explained
+in detail [here][1]. But take into account that it needs to be done manually.


For the same issue (#73) that was discovered later, I think this might not be accurate either. I'd remove this, probably. What do you think?

The link (the [1]), is also shared in the section below, so we still keep a reference for that useful doc :)

I guess it would work, if we enable mount propagation for this path, which we don't at the moment. I can remove it then.

Ok, removed now.

surajssd

This looks ok.

rata · 2020-02-13T14:48:09Z

@surajssd do you think it looks good to approve the PR? Can you approve it, then? :)

@invidian can you approve too? (not sure, it's weird, you addressed the last comments at least. But I can't approve as it is my PR :))

@pothos or maybe can you take a look and approve if it seems okay? :)

PS: I'd merge with squash and merge, if we are all ok with this (don't see value in the split commits)

invidian · 2020-02-13T14:51:35Z

@surajssd do you think it looks good to approve the PR? Can you approve it, then? :)

@surajssd already approved it, but it got dismissed by my push. Let me squash the commits then.

This adds basic documentation on how to use node local storage using local persistent volumes in filesystem mode. Other sections are mentioned, although empty for now, on other ways to use it that we may want to expand later.

invidian

Approving on behalf of @rata

rata · 2020-02-13T16:57:15Z

Merging on behalf of @invidian ? 😂

rata · 2020-02-13T16:58:44Z

@invidian thanks a lot for driving this forward! :)

rata requested review from t-lo, kosyfrances, johananl and invidian August 13, 2019 15:55

pothos reviewed Aug 13, 2019

View reviewed changes

docs/advanced/node-local-storage.md Outdated Show resolved Hide resolved

pothos reviewed Aug 13, 2019

View reviewed changes

docs/advanced/node-local-storage.md Outdated Show resolved Hide resolved

pothos reviewed Aug 13, 2019

View reviewed changes

docs/advanced/node-local-storage.md Outdated Show resolved Hide resolved

pothos reviewed Aug 13, 2019

View reviewed changes

docs/advanced/node-local-storage.md Outdated Show resolved Hide resolved

pothos reviewed Aug 13, 2019

View reviewed changes

docs/advanced/node-local-storage.md Outdated Show resolved Hide resolved

pothos reviewed Aug 13, 2019

View reviewed changes

docs/advanced/node-local-storage.md Outdated Show resolved Hide resolved

pothos reviewed Aug 13, 2019

View reviewed changes

docs/advanced/node-local-storage.md Outdated Show resolved Hide resolved

pothos reviewed Aug 13, 2019

View reviewed changes

docs/advanced/node-local-storage.md Outdated Show resolved Hide resolved

pothos reviewed Aug 13, 2019

View reviewed changes

docs/advanced/node-local-storage.md Outdated Show resolved Hide resolved

pothos reviewed Aug 13, 2019

View reviewed changes

docs/advanced/node-local-storage.md Outdated Show resolved Hide resolved

invidian suggested changes Aug 14, 2019

View reviewed changes

rata force-pushed the rata/node-local-storage-docs branch 8 times, most recently from 9faf488 to c428f16 Compare August 14, 2019 11:16

rata requested a review from invidian August 14, 2019 11:32

invidian previously requested changes Aug 14, 2019

View reviewed changes

surajssd reviewed Aug 14, 2019

View reviewed changes

rata force-pushed the rata/node-local-storage-docs branch 2 times, most recently from bb76b2d to 9fd22f9 Compare September 2, 2019 17:13

rata requested a review from invidian September 2, 2019 17:45

kosyfrances reviewed Sep 9, 2019

View reviewed changes

kosyfrances reviewed Sep 23, 2019

View reviewed changes

invidian force-pushed the rata/node-local-storage-docs branch from 9fd22f9 to 898f696 Compare February 12, 2020 12:41

invidian requested a review from surajssd February 12, 2020 13:57

rata commented Feb 12, 2020

View reviewed changes

surajssd previously approved these changes Feb 13, 2020

View reviewed changes

invidian dismissed surajssd’s stale review via 23852c4 February 13, 2020 13:23

docs: Add initial docs on how to use node local storage

f235454

This adds basic documentation on how to use node local storage using local persistent volumes in filesystem mode. Other sections are mentioned, although empty for now, on other ways to use it that we may want to expand later.

invidian force-pushed the rata/node-local-storage-docs branch from 23852c4 to f235454 Compare February 13, 2020 14:51

invidian approved these changes Feb 13, 2020

View reviewed changes

rata merged commit 349499c into master Feb 13, 2020

rata deleted the rata/node-local-storage-docs branch February 13, 2020 16:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

docs: Add initial docs on how to use node local storage #51

docs: Add initial docs on how to use node local storage #51

rata commented Aug 13, 2019

invidian left a comment

rata commented Aug 14, 2019 •

edited

Loading

invidian left a comment

surajssd left a comment

surajssd Aug 14, 2019

rata Aug 14, 2019

rata commented Sep 2, 2019

kosyfrances left a comment

kosyfrances Sep 23, 2019

rata commented Sep 27, 2019

invidian commented Jan 6, 2020

rata commented Feb 6, 2020

invidian commented Feb 12, 2020

rata Feb 12, 2020 •

edited

Loading

rata Feb 12, 2020

rata commented Feb 12, 2020 •

edited

Loading

rata Feb 12, 2020

rata Feb 12, 2020

invidian Feb 13, 2020

invidian Feb 13, 2020

surajssd left a comment

rata commented Feb 13, 2020

invidian commented Feb 13, 2020

invidian left a comment

rata commented Feb 13, 2020

rata commented Feb 13, 2020

docs: Add initial docs on how to use node local storage #51

docs: Add initial docs on how to use node local storage #51

Conversation

rata commented Aug 13, 2019

invidian left a comment

Choose a reason for hiding this comment

rata commented Aug 14, 2019 • edited Loading

invidian left a comment

Choose a reason for hiding this comment

surajssd left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rata commented Sep 2, 2019

kosyfrances left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rata commented Sep 27, 2019

invidian commented Jan 6, 2020

rata commented Feb 6, 2020

invidian commented Feb 12, 2020

rata Feb 12, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rata commented Feb 12, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

surajssd left a comment

Choose a reason for hiding this comment

rata commented Feb 13, 2020

invidian commented Feb 13, 2020

invidian left a comment

Choose a reason for hiding this comment

rata commented Feb 13, 2020

rata commented Feb 13, 2020

rata commented Aug 14, 2019 •

edited

Loading

rata Feb 12, 2020 •

edited

Loading

rata commented Feb 12, 2020 •

edited

Loading