vtpm: add method to get sha256 PCRs from Quote #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jepio
reviewed
Feb 22, 2024
The internal representation of the PCRs has been changed to fixed-size array. Signed-off-by: Magnus Kulke <[email protected]>
mkulke
force-pushed
the
mkulke/expose-pcr-in-quote
branch
from
1cfccfc to
d652595
Compare
jepio
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a method to retrieve the PCR values from a quote.
Internally the PCRs are still represented as
Vec<Vec<u8>>, due to serialization concerns of large arrays. For the consumer a fixed byte arrayVec<[u8; 32]>is more convenient, so they don't have to perform runtime assertions on the vector size.How to use
Call
quote.pcrs_sha256()Testing done
A test has been added to make sure the transformation is non-destructive.
Ran
cargo semver-checksto make sure there is no breaking api change.