Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Internationalization #454

Merged
merged 18 commits into from
Feb 7, 2023
Merged

Internationalization #454

merged 18 commits into from
Feb 7, 2023

Conversation

bmcdorman
Copy link
Member

This PR adds internationalization support to the simulator (i.e., all strings in the UI are now translatable). See the README for documentation on how this system works.

Screenshots

Changing Locale

image

After Change

image

@bmcdorman bmcdorman marked this pull request as ready for review January 20, 2023 12:58
navzam
navzam reviewed Feb 3, 2023
View reviewed changes
i18n/po/ar-SA.po Outdated Show resolved Hide resolved
configs/webpack/common.js Show resolved Hide resolved
i18n/i18n.json Outdated Show resolved Hide resolved
src/Sim.tsx Outdated Show resolved Hide resolved
src/components/SettingsDialog.tsx Outdated Show resolved Hide resolved
navzam
navzam reviewed Feb 3, 2023
View reviewed changes
package.json Show resolved Hide resolved
navzam
navzam reviewed Feb 3, 2023
View reviewed changes
README.md Show resolved Hide resolved
navzam
navzam reviewed Feb 3, 2023
View reviewed changes
src/util/LocalizedString.ts Outdated Show resolved Hide resolved
@navzam
Copy link
Member

navzam commented Feb 7, 2023

Probably out of scope for this PR, but I created an issue for localization of the login/signup page: #459

navzam
navzam reviewed Feb 7, 2023
View reviewed changes
README.md Show resolved Hide resolved
@tcorbly tcorbly merged commit f742e28 into master Feb 7, 2023
@tcorbly tcorbly deleted the internationalization branch February 7, 2023 21:28
@navzam navzam mentioned this pull request Feb 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@navzam navzam navzam approved these changes

@tcorbly tcorbly Awaiting requested review from tcorbly

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bmcdorman @navzam @tcorbly