Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove retries (e2e) #427

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

kirillzyusko
Copy link
Owner

@kirillzyusko kirillzyusko commented Apr 26, 2024

📜 Description

Removed retries that were added in #392

💡 Motivation and Context

A new image with iOS 17.5 was released (see actions/runner-images#9591 for more details and the problem with timeout has gone - simulators work much faster now).

So I'm reverting --retries 2 flag because it's not needed anymore - tests are pretty stable now.

📢 Changelog

E2E

  • removed retries;

🤔 How Has This Been Tested?

Tested on CI.

📸 Screenshots (if appropriate):

📝 Checklist

  • CI successfully passed
  • I added new mocks and corresponding unit-tests if library API was changed

@kirillzyusko kirillzyusko added the e2e Anything about E2E tests label Apr 26, 2024
@kirillzyusko kirillzyusko self-assigned this Apr 26, 2024
Copy link
Contributor

github-actions bot commented Apr 26, 2024

📊 Package size report

Current size Target Size Difference
135974 bytes 135974 bytes 0 bytes 📉

@kirillzyusko kirillzyusko force-pushed the chore/remove-retries-from-e2e branch from 18521dc to 6c950dd Compare May 7, 2024 10:40
@kirillzyusko kirillzyusko marked this pull request as ready for review May 7, 2024 11:02
@kirillzyusko kirillzyusko force-pushed the chore/remove-retries-from-e2e branch from 6c950dd to 81f7f32 Compare May 13, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Anything about E2E tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant