Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide SDK as source rather than a prebuilt framework in podspec #5

Closed
wants to merge 2 commits into from

Conversation

jchambers
Copy link

This is a podspec that builds the KISSmetrics iOS SDK from source rather than including a prebuilt framework. This fixes #4.

@jchambers jchambers changed the title Provide SDK as source rather than prebuilt framework in podspec Provide SDK as source rather than a prebuilt framework in podspec Jun 26, 2014
@willrust
Copy link
Contributor

Hi Jon, I really appreciate your attention to this issue but I don't feel that moving from a framework is a good solution to the problem. If there's something wrong with the current podspec I'd much rather fix it there.

@willrust willrust closed this Jun 26, 2014
@jchambers
Copy link
Author

…I don't feel that moving from a framework is a good solution to the problem.

I don't mean to be difficult, but could you elaborate?

My proposal isn't to abandon the framework entirely. My understanding is that it's very common -- for open-source projects, at least -- to provide a source distribution via cocoapods and a binary (framework) distribution by other means. Binary-only pods are, in my experience, generally used as a last resort when the source can't be made public for some reason.

Thanks for your consideration!

@willrust
Copy link
Contributor

Well, one thing is that it allows us to use ARC in our source and the compiled framework can still be used in legacy non-ARC projects without having to flag every file.

But that really isn't why I disagree with this solution to the problem. Though it may get around the issue with the pod, I don't think it's addressing the problem in the right place. I'm still hopeful that we can figure out what definitions are incorrect in our podspec to get this working for everyone and not just some people.

I've left the issue open and will be working on it. Just have a few other things to take care of at the moment and the workaround for it is fairly painless.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Podspec does not work
2 participants