fix wrong test results for zero-point mandatory tests (fixes #60)

kit-sdq · Oct 17, 2024 · 6aa0d96 · 6aa0d96
1 parent 8730d7a
commit 6aa0d96
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/src/main/java/edu/kit/kastel/sdq/intelligrade/extensions/guis/TestCasePanel.java b/src/main/java/edu/kit/kastel/sdq/intelligrade/extensions/guis/TestCasePanel.java
@@ -28,9 +28,11 @@ public TestCasePanel() {
             for (var result : testResults) {
                 String tooltip = result.getDetailText().orElse("No details available");
 
-                var icon = result.getPoints() != 0.0
-                        ? AllIcons.RunConfigurations.TestPassed
-                        : AllIcons.RunConfigurations.TestFailed;
+                // isPositive() is true if the test passed, regardless of its points
+                // (which may be zero for mandatory tests)
+                var icon = result.getPositive()
+                        .map(p -> p ? AllIcons.RunConfigurations.TestPassed : AllIcons.RunConfigurations.TestFailed)
+                        .orElse(AllIcons.RunConfigurations.TestUnknown);
                 var iconLabel = new JBLabel(icon);
                 iconLabel.setToolTipText(tooltip);
                 this.content.add(iconLabel);