Skip to content

Commit

Permalink
Remove assignment of parentRegionId in Highlight class
Browse files Browse the repository at this point in the history
  • Loading branch information
beatrycze-volk committed Oct 24, 2023
1 parent 64ee591 commit 1e2fbb4
Showing 1 changed file with 2 additions and 9 deletions.
11 changes: 2 additions & 9 deletions Classes/Common/Solr/SearchResult/Highlight.php
Original file line number Diff line number Diff line change
Expand Up @@ -29,14 +29,6 @@ class Highlight
*/
private string $id;

/**
* @access private
* @var int The parent region's identifier
*/
// this property is currently assigned but not used
// @phpstan-ignore-next-line
private int $parentRegionId;

/**
* @access private
* @var int The horizontal beginning position of found highlight
Expand Down Expand Up @@ -72,7 +64,8 @@ class Highlight
*/
public function __construct(array $highlight)
{
$this->parentRegionId = $highlight['parentRegionIdx'];
// there is also possibility to access parentRegionIdx
// $this->parentRegionId = $highlight['parentRegionIdx'];
$this->xBeginPosition = $highlight['ulx'];
$this->xEndPosition = $highlight['lrx'];
$this->yBeginPosition = $highlight['uly'];
Expand Down

0 comments on commit 1e2fbb4

Please sign in to comment.