[MAINTENANCE] Introduce usage of PHPStan checks for new PR #1052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastian-meyer
added
the
🛠 maintenance
sebastian-meyer
changed the title
sebastian-meyer
requested changes
Oct 23, 2023
There was a problem hiding this comment.
Thank you very much for this pull request! I appreciate your hard work on improving and maintaining the code quality! Overall this looks very good and I'd like to add PHPStan to our array of static code analyzers.
What I don't like are a lot of those // @phpstan-ignore-next-line comments, which suggest, that there is some error in the code. Please, either also add a TODO to indicate what is wrong (as you did many times) or try to change PHPStan's configuration in order to not report false positives. (Disclaimer: I am no expert with PHPStan, so maybe my request is unrealistic...)
beatrycze-volk
force-pushed
the
phpstan
branch
from
e8935cd
to
8b0bc8a
Compare
Changes for controller and domain classes
Co-authored-by: Sebastian Meyer <[email protected]>
Co-authored-by: Sebastian Meyer <[email protected]>
Co-authored-by: Sebastian Meyer <[email protected]>
beatrycze-volk
force-pushed
the
phpstan
branch
2 times, most recently
from
447bc44
to
0e46263
Compare
beatrycze-volk
force-pushed
the
phpstan
branch
from
0e46263
to
64ee591
Compare
sebastian-meyer
previously approved these changes
Oct 24, 2023
beatrycze-volk
commented
Oct 24, 2023
sebastian-meyer
requested changes
Oct 24, 2023
sebastian-meyer
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #1045