-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUGFIX] Add languageUid
to index_name
to make it unique
#1186
Conversation
languageUid
to index_name
to make it uniquelanguageUid
to index_name
to make it unique
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am wondering if we would need to change the default translation method as well. What happens if we manually translate a metadata record in the backend? I assume the translated record would also get an exact copy of the original index_name
triggering the same issues when moving the newly translated record around...
Maybe we need to work around this by changing the l10n_mode
from 'exclude' to 'prefixLangTitle' and set TCEMAIN.translateToMessage
to an appropriate prefix (like '%s_').
Signed-off-by: Christos Sidiropoulos <[email protected]>
Signed-off-by: Christos Sidiropoulos <[email protected]>
937332e
to
9459222
Compare
@csidirop Could you please verify that this also works for records manually translated in the backend? What does the |
@beatrycze-volk Is this potentially also related to not using the DataHandler in the backend (like in #1184)? |
That is quiet possible. With |
So then this should be fixed with your re-introduction of the DataHandler as mentioned in #1184. Nice! I'll leave this PR for now, because consistently using the DataHandler would be the better solution. |
Reverting to using the DataHandler is more work than anticipated. Therefor I'll merge this workaround for now in order to release version 5.0. |
Fixes #1182 and the issues described in #1182 (comment) .