Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Add languageUid to index_name to make it unique #1186

Merged
merged 3 commits into from
May 23, 2024

Conversation

csidirop
Copy link
Contributor

@csidirop csidirop commented Mar 7, 2024

Fixes #1182 and the issues described in #1182 (comment) .

@sebastian-meyer sebastian-meyer self-requested a review March 7, 2024 14:49
@sebastian-meyer sebastian-meyer added the 🐛 bug A non-security related bug. label Mar 7, 2024
@sebastian-meyer sebastian-meyer changed the title Add languageUid to index_name to make it unique [BUGFIX] Add languageUid to index_name to make it unique Mar 7, 2024
Copy link
Member

@sebastian-meyer sebastian-meyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am wondering if we would need to change the default translation method as well. What happens if we manually translate a metadata record in the backend? I assume the translated record would also get an exact copy of the original index_name triggering the same issues when moving the newly translated record around...

Maybe we need to work around this by changing the l10n_mode from 'exclude' to 'prefixLangTitle' and set TCEMAIN.translateToMessage to an appropriate prefix (like '%s_').

Classes/Controller/Backend/NewTenantController.php Outdated Show resolved Hide resolved
Signed-off-by: Christos Sidiropoulos <[email protected]>
@sebastian-meyer
Copy link
Member

@csidirop Could you please verify that this also works for records manually translated in the backend? What does the index_name of those records look like?

@sebastian-meyer
Copy link
Member

@beatrycze-volk Is this potentially also related to not using the DataHandler in the backend (like in #1184)?

@beatrycze-volk
Copy link
Collaborator

@beatrycze-volk Is this potentially also related to not using the DataHandler in the backend (like in #1184)?

That is quiet possible. With DataHandler translated records were created automatically not like now manually.

@sebastian-meyer
Copy link
Member

So then this should be fixed with your re-introduction of the DataHandler as mentioned in #1184. Nice!

I'll leave this PR for now, because consistently using the DataHandler would be the better solution.

@sebastian-meyer
Copy link
Member

Reverting to using the DataHandler is more work than anticipated. Therefor I'll merge this workaround for now in order to release version 5.0.
I'll open a new issue for DataHandler usage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug A non-security related bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Metadata index_name still gets changed when moving metadata in list
3 participants