Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Fix assignment of storagePid and streamline initializeRepositories in BaseCommand #1219

Merged
merged 2 commits into from
May 29, 2024

Conversation

beatrycze-volk
Copy link
Collaborator

No need to check if int is int inside the initializeRepositories() function, instead of it getOption('pid') should be casted to int, otherwise error will be thrown here.

@sebastian-meyer sebastian-meyer self-requested a review May 29, 2024 12:12
@sebastian-meyer sebastian-meyer added the 🐛 bug A non-security related bug. label May 29, 2024
@sebastian-meyer sebastian-meyer merged commit 8d37dc1 into kitodo:master May 29, 2024
7 checks passed
sebastian-meyer added a commit that referenced this pull request May 29, 2024
…ositories` in `BaseCommand` (#1219)

Co-authored-by: Sebastian Meyer <[email protected]>
@beatrycze-volk beatrycze-volk deleted the storagepid branch May 29, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug A non-security related bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants