Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINTENANCE] Adjust compability with PHP 8 for XML loading #1223

Merged
merged 1 commit into from
May 29, 2024

Conversation

beatrycze-volk
Copy link
Collaborator

On code that only runs on PHP 8.0 and later, it is now safe to remove all function calls.
For versions prior to PHP 8, a conditional call.

https://php.watch/versions/8.0/libxml_disable_entity_loader-deprecation

@sebastian-meyer sebastian-meyer self-requested a review May 29, 2024 16:26
@sebastian-meyer sebastian-meyer added the 🛠 maintenance A task to keep the code up-to-date and manageable. label May 29, 2024
@sebastian-meyer sebastian-meyer merged commit 9323999 into kitodo:master May 29, 2024
7 checks passed
@beatrycze-volk beatrycze-volk deleted the loadxml branch May 29, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🛠 maintenance A task to keep the code up-to-date and manageable.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants