Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Add MIME type filter to ensure only supported image files are downloaded #1319

Merged

Conversation

fschoelzel
Copy link
Contributor

@fschoelzel fschoelzel commented Aug 28, 2024

The filter is necessary because the method would otherwise let the user download any file present in mets:fileGrp DEFAULT.

The filter is necessary because the method would otherwise download any file present in mets:fileGrp DEFAULT.
@fschoelzel
Copy link
Contributor Author

As it says Image Download only and there is an additional PDF Download, the mimetype "application/pdf" can probably be removed in the image constants list.

@sebastian-meyer sebastian-meyer changed the title Add MIME type filter to ensure only supported image files are downloaded [FEATURE] Add MIME type filter to ensure only supported image files are downloaded Sep 9, 2024
@sebastian-meyer sebastian-meyer added the ⚙ feature A new feature or enhancement. label Sep 9, 2024
@sebastian-meyer sebastian-meyer merged commit 1cbe0a9 into kitodo:master Sep 9, 2024
7 checks passed
@fschoelzel fschoelzel deleted the feature-imagedownload-filter branch September 9, 2024 15:31
fschoelzel added a commit to fschoelzel/kitodo-presentation that referenced this pull request Sep 9, 2024
sebastian-meyer added a commit that referenced this pull request Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚙ feature A new feature or enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants