[BUGFIX] Fix broken URL generation for routes in GridView #1327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Bernd Fallert <[email protected]> Signed-off-by: Christos Sidiropoulos <[email protected]>
sebastian-meyer
changed the title
sebastian-meyer
approved these changes
Sep 9, 2024
sebastian-meyer
added a commit
that referenced
this pull request
Sep 20, 2024
Signed-off-by: Christos Sidiropoulos <[email protected]> Co-authored-by: Bernd Fallert <[email protected]> Co-authored-by: Sebastian Meyer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #1326
We are simply adding the missing parameter to the
additionalParamsarray.My colleague (@BFallert) implemented this fix months ago for our instances and it works as expected.
Unfortunately I've only tested it with 5.x branch (PHP 7.4 and TYPO3 v10.4.38) because the main is not working good enough at this moment. But this should be fine. On the other hand this isn't a critical bug and can wait till the main ist stable enough.