Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX] Call sanitizeSettings function in loadDocument of AbstractController #1334

Merged
merged 2 commits into from
Sep 20, 2024
Merged

[BUGFIX] Call sanitizeSettings function in loadDocument of AbstractController #1334

merged 2 commits into from
Sep 20, 2024

Conversation

beatrycze-volk
Copy link
Collaborator

I have forgotten push last commit from branch in #1324

Closes #1329

@beatrycze-volk
Copy link
Collaborator Author

4 tests with failures will be gone after #1330 is merged

8 tests with errors are coming from OaiPmhTest class and are probably related to setting of default values. There is possibility that those tests were actually depending on missing settings and now when those settings are there it cause problem. I will look into it,

@beatrycze-volk
Copy link
Collaborator Author

Logger can be accessed in constructor if this feature will be implemented: https://docs.typo3.org/m/typo3/reference-coreapi/11.5/en-us/ApiOverview/Logging/Logger/Index.html#instantiation

@beatrycze-volk beatrycze-volk changed the title [BUGFIX] Call sanitizeSettings function in initialize of AbstractController [BUGFIX] Call sanitizeSettings function in loadDocument of AbstractController Sep 19, 2024
@sebastian-meyer sebastian-meyer added the 🐛 bug A non-security related bug. label Sep 20, 2024
@sebastian-meyer sebastian-meyer merged commit 2e61841 into kitodo:master Sep 20, 2024
7 checks passed
@fschoelzel fschoelzel mentioned this pull request Sep 20, 2024
Closed
sebastian-meyer added a commit that referenced this pull request Sep 20, 2024
@beatrycze-volk @sebastian-meyer
[BUGFIX] Call sanitizeSettings function in loadDocument of `Abstr…
0377a5e 
…actController` (#1334)

Co-authored-by: Sebastian Meyer <[email protected]>
@beatrycze-volk beatrycze-volk deleted the call-init branch September 23, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastian-meyer sebastian-meyer sebastian-meyer approved these changes

Assignees

@beatrycze-volk beatrycze-volk

Labels
🐛 bug A non-security related bug.
Projects
None yet
Milestone
Kitodo.Presentation 5.1.0
Development

Successfully merging this pull request may close these issues.

[BUG] setCPid() must be of the type int, null given
2 participants
@beatrycze-volk @sebastian-meyer