chore: add yarn lint to ci

kitsteam · Apr 13, 2024 · a1df998 · a1df998
1 parent 5bf6b7e
commit a1df998
Show file tree

Hide file tree

Showing 6 changed files with 36 additions and 19 deletions.
diff --git a/.eslintrc.json b/.eslintrc.json
@@ -1,24 +1,32 @@
 {
   "root": true,
-  "ignorePatterns": ["projects/**/*"],
+  "ignorePatterns": [
+    "projects/**/*"
+  ],
   "overrides": [
     {
-      "files": ["*.ts"],
+      "files": [
+        "*.ts"
+      ],
       "parserOptions": {
-        "project": ["tsconfig.json", "e2e/tsconfig.json"],
+        "project": [
+          "tsconfig.json"
+        ],
         "createDefaultProgram": true
       },
       "extends": [
-        "plugin:@angular-eslint/ng-cli-compat",
-        "plugin:@angular-eslint/ng-cli-compat--formatting-add-on",
+        "plugin:@angular-eslint/recommended",
         "plugin:@angular-eslint/template/process-inline-templates"
       ],
       "rules": {
         "no-console": 0,
         "@angular-eslint/component-class-suffix": [
           "error",
           {
-            "suffixes": ["Page", "Component"]
+            "suffixes": [
+              "Page",
+              "Component"
+            ]
           }
         ],
         "@angular-eslint/component-selector": [
@@ -40,9 +48,13 @@
       }
     },
     {
-      "files": ["*.html"],
-      "extends": ["plugin:@angular-eslint/template/recommended"],
+      "files": [
+        "*.html"
+      ],
+      "extends": [
+        "plugin:@angular-eslint/template/recommended"
+      ],
       "rules": {}
     }
   ]
-}
+}
diff --git a/.github/workflows/on_push_branch_execute_ci.yml b/.github/workflows/on_push_branch_execute_ci.yml
@@ -23,4 +23,17 @@ jobs:
           node-version: ${{ env.NODE_VERSION }}
           cache: 'yarn'
       - run: yarn install --frozen-lockfile
-      - run: yarn test
+      - run: yarn test
+
+  yarn_lint:
+    steps:
+      - name: Check out repository code
+        uses: actions/checkout@v4
+      - name: Setup Node
+        uses: actions/setup-node@v4
+        with:
+          node-version: ${{ env.NODE_VERSION }}
+          cache: 'yarn'
+      - run: yarn install --frozen-lockfile
+      - run: yarn lint
+
diff --git a/src/app/components/header/header.component.ts b/src/app/components/header/header.component.ts
@@ -20,8 +20,6 @@ export class HeaderComponent extends BaseComponent implements OnInit {
         super(baseService);
     }
 
-    ngOnInit() {}
-
     onNavigate(url: string) {
         this.baseService.router.navigateByUrl(url);
     }

diff --git a/src/app/models/animator.ts b/src/app/models/animator.ts
@@ -10,7 +10,7 @@ import * as zip from '@zip.js/zip.js';
 import { MimeTypes } from '@enums/mime-types.enum';
 import { RecorderState } from '@enums/recorder-state.enum';
 import { ImagesService } from '@services/images/images.service';
-// eslint-disable-next-line @typescript-eslint/naming-convention
+
 declare const webm: any;
 @Injectable({
     providedIn: 'root'

diff --git a/src/app/pages/animator/components/thumbnails/thumbnails.component.ts b/src/app/pages/animator/components/thumbnails/thumbnails.component.ts
@@ -49,9 +49,6 @@ export class ThumbnailsComponent extends BaseComponent implements OnDestroy, OnI
     super(baseService);
   }
 
-  ngOnInit(): void {
-  }
-
   private initialiseThumbnailsContainer() {
     this.list = this.animatorService.getFrames().pipe(tap(async (frames: HTMLCanvasElement[]) => {
       this.framesLength = frames.length;

diff --git a/src/app/pages/settings/settings.page.ts b/src/app/pages/settings/settings.page.ts
@@ -17,7 +17,4 @@ export class SettingsPage extends BasePage implements OnInit {
     this.options.rightButton = false;
     this.options.backButton = true;
   }
-
-  ngOnInit() { }
-
 }