This repository has been archived by the owner on Sep 2, 2021. It is now read-only.
Hotels: patch code-push-init android #1493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgrade rnkiwimobile to 0.0.44 closes #1492
RobinCsl
reviewed
Mar 5, 2019
| @@ -7,7 +7,7 @@ this will be evened out from v24 | |||
|
|
|||
| ## Target version 9.0.0 | |||
|
|
|||
| - Upgrade rnkiwimobile to version `0.0.43` | |||
| - Upgrade rnkiwimobile to version `0.0.43` or `0.0.44`, both are compatible with this target-version. The latter contains a patch in the initialization of code-push to fix a crash when upating fails. | |||
There was a problem hiding this comment.
Add that the patch is only for Android.
There was a problem hiding this comment.
Yes, this versioning is only for android, iOS uses github releases
|
LGTM otherwise! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade rnkiwimobile to 0.0.44
closes #1492