WIP: Add ancillary factory fragment #1703
Conversation
KarinaDavtyan
requested review from
Blackhex,
RobinCsl and
tbergquist-godaddy
as code owners
Isnt the one in the build folder just for hotels or its just the same name? And in the |
No, it is for the integration used by android team. Probably a good idea to rename it. Could you create an issue for that?
Yes, that is the one |
|
Okay, thanks! will update
Sure, issue done #1704 |
...oid/playground/src/main/java/com/kiwi/mobile/rnandroidplayground/AncillaryFactoryFragment.kt
Outdated
Show resolved
Hide resolved
| import com.kiwi.rnkiwimobile.ancillaries.RNAncillaryFactoryInitialProperties | ||
|
|
||
|
|
||
| class AncillaryFactoryFragment: RNAncillaryFactoryFragment(RNAncillaryFactoryInitialProperties(service = "fast_track", bookingId = 123, kwAuthToken = "mock")) { |
There was a problem hiding this comment.
it is. Not sure what is the proper way to make it shorter. But I tried making it shorter
android/playground/src/main/java/com/kiwi/mobile/rnandroidplayground/AncillaryFactoryAcivity.kt
Outdated
Show resolved
Hide resolved
|
|
||
| import com.kiwi.rnkiwimobile.RNKiwiFragment; | ||
|
|
||
| abstract class RNAncillaryFactoryFragment(initialProperties: RNAncillaryFactoryInitialProperties) : RNKiwiFragment(RNAncillaryFactoryModule.getInitialProperties(initialProperties)) { |
There was a problem hiding this comment.
Is there some equivalent of eslint for this maybe?
There was a problem hiding this comment.
Same here not sure if I escaped to new line properly.
...d/rnkiwimobile/src/main/java/com/kiwi/rnkiwimobile/ancillaries/RNAncillaryFactoryFragment.kt
Outdated
Show resolved
Hide resolved
KarinaDavtyan
force-pushed
the
add-ancillary-factory-fragment
branch
from
779ec2a
to
8333a08
Compare
Add ancillary factory Fragment which would be used to show ancillary services on Android.
Also addFragment to the playground