feat: add dark mode support #4548
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
- Add colorScheme prop to OrbitProvider component - Add dark mode tokens and palette - Update documentation with new colorScheme prop - Maintain backward compatibility with existing theme system Co-Authored-By: Jozef Képesi <[email protected]>
- Add useColorScheme hook for dark mode detection - Add tests for light, dark, and system color schemes - Export hook in index.ts - Support window.matchMedia for system preference detection Co-Authored-By: Jozef Képesi <[email protected]>
…hook - Add colorScheme prop to OrbitProvider - Create useColorScheme hook for theme-aware components - Add dark mode tokens and styles - Update Modal and InputField with dark mode support - Add DarkModeWrapper test utility Co-Authored-By: Jozef Képesi <[email protected]>
Deploying orbit with
|
| Latest commit: |
1e8156e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://9716a5d9.orbit.pages.dev |
| Branch Preview URL: | https://devin-1734021785-dark-mode-s.orbit.pages.dev |
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
⚙️ Control Options:
Add "(aside)" to your comment to have me ignore it. |
|
Storybook staging is available at https://kiwicom-orbit-devin-1734021785-dark-mode-support.surge.sh |
|
Size Change: +666 B (+0.14%) Total Size: 461 kB
ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dark Mode Support
This PR adds dark mode support to Orbit components through the OrbitProvider's new colorScheme prop.
Changes
Theme API Changes
The colorScheme prop accepts:
Visual Changes
Before/After screenshots will be added once the visual regression tests complete.
Link to Devin run: https://app.devin.ai/sessions/7f5e6966a6ab4b08a495ed623bc32d1b
✨
Description by Callstackai
This PR adds dark mode support to Orbit components through the new
colorSchemeprop inOrbitProvider, along with a custom hookuseColorSchemefor theme-aware components.Diagrams of code changes
sequenceDiagram participant App participant OrbitProvider participant useColorScheme participant System App->>OrbitProvider: Initialize with colorScheme prop Note over OrbitProvider: Supports "light", "dark", or "system" alt colorScheme is "system" OrbitProvider->>System: Check system preferences System-->>OrbitProvider: Return preferred scheme else colorScheme is "dark" OrbitProvider->>OrbitProvider: Use dark mode else colorScheme is "light" OrbitProvider->>OrbitProvider: Use light mode (default) end OrbitProvider->>App: Apply theme with color scheme Note over App: Components can check<br/>current scheme using<br/>useColorScheme hookFiles Changed
colorSchemeprop inOrbitProvider.OrbitProviderto accept and handle thecolorSchemeprop.colorSchemeprop.colorSchemeproperty.useColorSchemehook to verify dark mode functionality.useColorSchemehook to determine the current color scheme.useColorSchemehook.DarkModeWrapperfor testing components in dark mode.This PR includes files in programming languages that we currently do not support. We have not reviewed files with the extensions
.md,.json. See list of supported languages.