Update v19 migration guide with size prop removal #4558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Storybook staging is available at https://kiwicom-orbit-dsil-update-v19-migration-guide-size.surge.sh |
|
Size Change: 0 B Total Size: 460 kB ℹ️ View Unchanged
|
Deploying orbit with
|
| Latest commit: |
955fe15
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://20f85601.orbit.pages.dev |
| Branch Preview URL: | https://dsil-update-v19-migration-gu.orbit.pages.dev |
mvidalgarcia
approved these changes
Dec 20, 2024
The following breaking changes were missing from the migration guide: - The size prop was removed from InputGroup - The inputSize prop was removed from ErrorFormTooltip.
DSil
force-pushed
the
dsil/update-v19-migration-guide-size
branch
from
f09f1e2 to
955fe15
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following breaking changes were missing from the migration guide:
✨
Description by Callstackai
This PR updates the v19 migration guide to include the removal of the
sizeprop fromInputGroupand theinputSizeprop fromErrorFormTooltip.Diagrams of code changes
sequenceDiagram participant Dev as Developer participant App as Application participant Components as UI Components Dev->>App: Start Migration to v19 rect rgb(200, 200, 200) Note over Dev,Components: Component Updates Dev->>Components: Replace UserSingle with UserSingleLight Dev->>Components: Remove size prop from InputGroup Dev->>Components: Remove inputSize prop from ErrorFormTooltip end App->>Components: Use Updated Components Note over App,Components: All components now use simplified propsFiles Changed
sizeandinputSizeprops.This PR includes files in programming languages that we currently do not support. We have not reviewed files with the extensions
.mdx. See list of supported languages.